Skip to content

chore(deps): update dependency nokogiri to v1.19.1 [security] #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency nokogiri to v1.19.1 [security] #3398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/build/developer-tools/build/data/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ GEM
net-ssh-gateway (2.0.0)
net-ssh (>= 4.0.0)
netrc (0.11.0)
nokogiri (1.18.9)
nokogiri (1.19.2)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The Gemfile.lock has been updated to version 1.19.2, which addresses the security vulnerability (GHSA-wx95-c6cv-8532). However, there are two points of concern:

  1. PR Metadata Mismatch: The PR title and description specify version 1.19.1. While 1.19.2 is a valid patch release containing the fix, the PR metadata should be updated for accuracy.
  2. Dependency Constraint: The DEPENDENCIES section (line 812) still shows nokogiri (~> 1.18), indicating that the Gemfile itself was not updated. To prevent the accidental reintroduction of vulnerable versions (like 1.18.9) in future dependency resolutions, the Gemfile should be updated to require nokogiri version 1.19.1 or higher (e.g., ~> 1.19).

mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nori (2.7.1)
Expand Down
Loading