chore(deps): update dependency nokogiri to v1.19.1 [security]#3398
Open
renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
chore(deps): update dependency nokogiri to v1.19.1 [security]#3398renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Collaborator
|
/gcbrun |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the nokogiri dependency in Gemfile.lock from version 1.18.9 to 1.19.2 to address a security vulnerability. Feedback suggests correcting the PR metadata to match the version used and updating the Gemfile constraint to ~> 1.19 to prevent future downgrades to vulnerable versions.
| net-ssh (>= 4.0.0) | ||
| netrc (0.11.0) | ||
| nokogiri (1.18.9) | ||
| nokogiri (1.19.2) |
Contributor
There was a problem hiding this comment.
The Gemfile.lock has been updated to version 1.19.2, which addresses the security vulnerability (GHSA-wx95-c6cv-8532). However, there are two points of concern:
- PR Metadata Mismatch: The PR title and description specify version
1.19.1. While1.19.2is a valid patch release containing the fix, the PR metadata should be updated for accuracy. - Dependency Constraint: The
DEPENDENCIESsection (line 812) still showsnokogiri (~> 1.18), indicating that theGemfileitself was not updated. To prevent the accidental reintroduction of vulnerable versions (like1.18.9) in future dependency resolutions, theGemfileshould be updated to requirenokogiriversion1.19.1or higher (e.g.,~> 1.19).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.18.9→1.19.1GitHub Vulnerability Alerts
GHSA-wx95-c6cv-8532
Summary
Nokogiri's CRuby extension fails to check the return value from
xmlC14NExecutein the methodNokogiri::XML::Document#canonicalizeandNokogiri::XML::Node#canonicalize. When canonicalization fails, an empty string is returned instead of raising an exception. This incorrect return value may allow downstream libraries to accept invalid or incomplete canonicalized XML, which has been demonstrated to enable signature validation bypass in SAML libraries.JRuby is not affected, as the Java implementation correctly raises
RuntimeErroron canonicalization failure.Mitigation
Upgrade to Nokogiri
>= 1.19.1.Severity
The maintainers have assessed this as Medium severity. Nokogiri itself is a parsing library without a clear security boundary related to canonicalization, so the direct impact is that a method returns incorrect data on invalid input. However, this behavior was exploited in practice to bypass SAML signature validation in downstream libraries (see References).
Credit
This vulnerability was responsibly reported by HackerOne researcher
d4d.Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.