Skip to content

feat(history): restore responsive selector header and sidebar-aware margin - #1480

Merged
Alan-TheGentleman merged 1 commit into
mainfrom
feat/history-responsive-header
Sep 26, 2026
Merged

Alan-TheGentleman merged 1 commit into
mainfrom
feat/history-responsive-header

Conversation

@Alan-TheGentleman

@Alan-TheGentleman Alan-TheGentleman commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #1479

Summary

Changes

File Change
extensions/history/index.ts Three-mode header layout, compact list rows, live overlay margin, wheel band per layout.
extensions/history/selector-helpers.ts planHeaderLayout, scope radio text, editorOverlayMargin reading railColumns.
lib/shell-sidebar.ts, lib/shell-sidebar-layout.ts SidebarState.railColumns, set by installSidebar.
docs/prompt-history.md New "Selector layout" section.
tests/… Contributor's header and margin suites restored and adapted, plus rendered-layout and real sidebar seam coverage.

Test plan

  • node --experimental-strip-types --test tests/*.test.ts → 3848 pass, 0 fail, 43 skipped.
  • node scripts/check-types.mjs → no regressions against the recorded baseline.
  • Native review approved.

Summary by CodeRabbit

  • New Features
    • The history selector now adapts its header to terminal width, stacking or abbreviating controls when space is limited.
    • The selector stays within the editor column when a fullscreen sidebar is visible and adjusts as the sidebar width changes.
    • The selector maintains a consistent 30-row height across layouts.
  • Documentation
    • Added guidance on responsive layouts and sidebar-aware positioning.

…argin

Bring back the responsive header layouts and the sidebar-aware overlay
margin that were split out of the GC slice (e2cca1f), adapted to the
current selector structure. The sidebar now publishes its rail width
through SidebarState.railColumns instead of a hardcoded constant.

Co-authored-by: Carolina <26188349+carolitascl@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d4c234bb-2756-4e8d-a96c-f73ced770322

📥 Commits

Reviewing files that changed from the base of the PR and between 5167c5c and 4c89734.

📒 Files selected for processing (11)
  • docs/prompt-history.md
  • extensions/history/index.ts
  • extensions/history/selector-helpers.ts
  • lib/shell-sidebar-layout.ts
  • lib/shell-sidebar.ts
  • odd/tasks/history-followups.md
  • tests/history-header-layout.test.ts
  • tests/history-lazy-windowing.test.ts
  • tests/history-openflow-integration.test.ts
  • tests/history-overlay-margin.test.ts
  • tests/history-wheel-mouse.test.ts
 ________________________________________________________________________________________________
< Your code and I have a love-hate relationship. I love finding bugs, you hate that I find them. >
 ------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Alan-TheGentleman
Alan-TheGentleman merged commit 50b2af7 into main Sep 26, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(history): responsive selector header and sidebar-aware overlay margin

1 participant