Skip to content

fix(history): resolve review advisories on carry, notices and layout - #1482

Merged
Alan-TheGentleman merged 1 commit into
mainfrom
fix/history-review-advisories
Sep 26, 2026
Merged

Alan-TheGentleman merged 1 commit into
mainfrom
fix/history-review-advisories

Conversation

@Alan-TheGentleman

@Alan-TheGentleman Alan-TheGentleman commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #1481

Summary

Changes

File Change
extensions/history/store.ts drainGlobal and deleteFromGlobal include global seed carry siblings; trimTornTail drops a torn partial append before the sibling fallback.
extensions/history/index.ts Full scope radio only when width >= radio + 1 (leading space in stacked/compact).
docs/prompt-history.md Carry files belong to the scope of the file they came from.
tests/… A1/A3/A5 regressions, A2 proof that the session-derived path never claims hidden, A4 live overlay margin/visibility across the 140-column breakpoint and sidebar removal.

Test plan

  • node --experimental-strip-types --test tests/*.test.ts → 3854 pass, 0 fail, 43 skipped.
  • node scripts/check-types.mjs → no regressions against the recorded baseline.
  • Native review approved.

Summary by CodeRabbit

  • Bug Fixes

    • Global history now includes related carry-over entries when viewing or deleting history, preventing entries from being missed or left behind.
    • Failed attempts to hide a prompt during deletion now report the error and keep the history row, rather than implying the prompt was hidden.
    • History picker labels now fit correctly at narrow terminal widths.
  • Documentation

    • Clarified that carry-over files follow the scope of their source file and are included in later deletions.

@Alan-TheGentleman Alan-TheGentleman added the type:bug Bug fix label Sep 26, 2026
@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: dd0a8283-f2a1-4ec0-9a35-367984adf113

📥 Commits

Reviewing files that changed from the base of the PR and between 50b2af7 and 13e1407.

📒 Files selected for processing (8)
  • docs/prompt-history.md
  • extensions/history/index.ts
  • extensions/history/store.ts
  • odd/tasks/history-review-advisories.md
  • tests/history-delete-confirm.test.ts
  • tests/history-header-layout.test.ts
  • tests/history-overlay-margin.test.ts
  • tests/history-scope-delete.test.ts
 ______________________________________________
< Regex can do anything... badly. Let me help. >
 ----------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Alan-TheGentleman
Alan-TheGentleman merged commit b756b4f into main Sep 26, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(history): resolve review advisories from #1477 and #1480

1 participant