Skip to content

ci: build on Go 1.26.9 so govulncheck stops failing on six stdlib advisories #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GeiserX merged 1 commit into from
Oct 12, 2026
Merged

ci: build on Go 1.26.9 so govulncheck stops failing on six stdlib advisories #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/catalog-drift.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
persist-credentials: false
- uses: actions/setup-go@v7
with:
go-version: '1.26.8'
go-version: '1.26.9'
cache: true

# The ref goes through the environment rather than straight into the run
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
persist-credentials: false
- uses: actions/setup-go@v7
with:
go-version: '1.26.8'
go-version: '1.26.9'
cache: true

- name: Build
Expand Down Expand Up @@ -138,7 +138,7 @@ jobs:
persist-credentials: false
- uses: actions/setup-go@v7
with:
go-version: '1.26.8'
go-version: '1.26.9'
cache: true
- name: Install govulncheck
run: go install golang.org/x/vuln/cmd/govulncheck@latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/desktop-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:

- uses: actions/setup-go@v7
with:
go-version: '1.26.8'
go-version: '1.26.9'
cache: true

- uses: actions/setup-node@v7
Expand Down
4 changes: 2 additions & 2 deletions docs/SECURITY-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ present in the dependency tree. The job is a hard gate: a finding our code can r

## Go standard library

The release and CI workflows pin an exact toolchain, `go-version: '1.26.8'`, so a release built today and one
The release and CI workflows pin an exact toolchain, `go-version: '1.26.9'`, so a release built today and one
rebuilt next month use the same compiler and standard library. The cost of an exact pin is that Go security
releases do not arrive on their own: the workflows sat on `'1.26.5'` while go1.26.6 fixed five advisories our
code actually calls (`GO-2026-6218` net/url, `GO-2026-6090` crypto/tls, `GO-2026-6089` and `GO-2026-5026`
net/http, `GO-2026-5972` encoding/asn1), and those shipped in release binaries until the gate caught it.

The `govulncheck` gate is what keeps the pin honest. It runs against the pinned toolchain, so a stdlib advisory
our code can reach fails CI on the next pull request. When it does, or when a Go security release ships, bump
the pin in all three places (`ci.yml` twice, `desktop-release.yml` once) to the latest 1.26.x and let the gate
the pin in all four places (`ci.yml` twice, `desktop-release.yml` and `catalog-drift.yml` once each) to the latest 1.26.x and let the gate
confirm it.

If you build locally with an older toolchain you will see those findings. Update your Go toolchain.
Expand Down
Loading