You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like Scotch config in #310 resulted in some non-deterministic behavior which causes one integrated test to constantly fail baseline checks in GEOS-DEV/GEOS#2427. This was partly due to a bug in Scotch CMake that was recently fixed. To get fully reproducible behavior between runs, one must configure with SCOTCH_DETERMINISTIC=FULL cmake flag.
This PR updates Scotch to latest v7.0.8 that includes the fix and updates Spack package recipes to configure Scotch correctly. Note that this fix does not yet exist in upstream Spack, so my approach may differ from what package maintainers eventually decide on.
Once this is merged, GEOS-DEV/GEOS#2427 will be updated to a new GEOS_TPL_TAG.
Had some problems with system-installed flex version on Rocky linux, so went nuclear in last two commits and removed system installed flex/bison from all images 😅 Scotch is quite finicky when it comes to flex versions, so trying to just let spack install the right version. Could've done this just for two problematic images instead, but let's see if this works, might save some future headaches.
Had some problems with system-installed flex version on Rocky linux, so went nuclear in last two commits and removed system installed flex/bison from all images 😅 Scotch is quite finicky when it comes to flex versions, so trying to just let spack install the right version. Could've done this just for two problematic images instead, but let's see if this works, might save some future headaches.
I had similar issues with system-installed flex version on macOS. These changes make a lot of sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like Scotch config in #310 resulted in some non-deterministic behavior which causes one integrated test to constantly fail baseline checks in GEOS-DEV/GEOS#2427. This was partly due to a bug in Scotch CMake that was recently fixed. To get fully reproducible behavior between runs, one must configure with
SCOTCH_DETERMINISTIC=FULLcmake flag.This PR updates Scotch to latest v7.0.8 that includes the fix and updates Spack package recipes to configure Scotch correctly. Note that this fix does not yet exist in upstream Spack, so my approach may differ from what package maintainers eventually decide on.
Once this is merged, GEOS-DEV/GEOS#2427 will be updated to a new
GEOS_TPL_TAG.