Merged
Conversation
klevzoff
commented
May 9, 2023
src/coreComponents/linearAlgebra/unitTests/testKrylovSolvers.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/solidMechanics/SolidMechanicsLagrangianFEM.hpp
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/solidMechanics/SolidMechanicsLagrangianFEM.cpp
Outdated
Show resolved
Hide resolved
6aa101b to
a167fdc
Compare
dfbc927 to
742c689
Compare
742c689 to
9004d43
Compare
9004d43 to
2bb59cd
Compare
2bb59cd to
efde4b5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2427 +/- ##
===========================================
- Coverage 58.37% 58.35% -0.02%
===========================================
Files 1261 1264 +3
Lines 108697 109013 +316
===========================================
+ Hits 63450 63619 +169
- Misses 45247 45394 +147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
castelletto1
reviewed
Aug 4, 2025
castelletto1
reviewed
Aug 4, 2025
src/coreComponents/linearAlgebra/interfaces/hypre/HypreMatrix.cpp
Outdated
Show resolved
Hide resolved
1f0eaad to
13396c6
Compare
castelletto1
reviewed
Aug 4, 2025
castelletto1
approved these changes
Aug 4, 2025
Contributor
castelletto1
left a comment
There was a problem hiding this comment.
Looks great, thanks @klevzoff!
paveltomin
approved these changes
Aug 4, 2025
13396c6 to
ce77dbf
Compare
941dbff to
d026da0
Compare
paveltomin
reviewed
Aug 9, 2025
Contributor
Author
|
Need codeowners approval @rrsettgast |
d026da0 to
9da673f
Compare
9da673f to
1c36975
Compare
herve-gross
approved these changes
Aug 11, 2025
Contributor
herve-gross
left a comment
There was a problem hiding this comment.
Nothing of value to add for me here, but I do not want to hold it behind. Thanks!
Guotong-Ren
approved these changes
Aug 12, 2025
dkachuma
approved these changes
Aug 12, 2025
rrsettgast
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection of LAI-related changes extracted from my multiscale branch to be reviewed separately. I will post some comments later highlighting the most important changes.
Rebaseline needed due to change in default linear solver parameters.