shaders: improve GLSL diagnostics and source attribution - #22
Open
tritao wants to merge 2 commits into
Open
Conversation
tritao
changed the title
tritao
marked this pull request as ready for review
August 8, 2026 02:36
This was referenced Aug 8, 2026
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 10:27
2de6681 to
1f27e2c
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 11:06
1f27e2c to
130303e
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 11:41
130303e to
b5eebe2
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 12:06
b5eebe2 to
bd689d5
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
2 times, most recently
from
August 8, 2026 20:31
d4d9d02 to
0523569
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 20:44
0523569 to
e1be85f
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 9, 2026 02:02
e1be85f to
2a7c09c
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 9, 2026 02:34
2a7c09c to
05e987e
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
2 times, most recently
from
August 9, 2026 11:37
ede4b7a to
28d71e6
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 9, 2026 11:44
28d71e6 to
18c0808
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 9, 2026 14:55
18c0808 to
302cf92
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 17, 2026 15:52
cfc1617 to
2a5bdd9
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
2 times, most recently
from
August 18, 2026 09:24
da547f1 to
9242f9e
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
2 times, most recently
from
August 18, 2026 18:12
603f57c to
f83d763
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 18, 2026 19:52
f83d763 to
27c6ee0
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 18, 2026 23:20
27c6ee0 to
5fd4a80
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 19, 2026 01:16
5fd4a80 to
8441be3
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 19, 2026 01:34
8441be3 to
ea463d7
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 19, 2026 02:14
ea463d7 to
0971d10
Compare
Lgt2x
reviewed
Aug 19, 2026
Comment on lines
+152
to
+155
| ${PROJECT_SOURCE_DIR}/src | ||
| ${PROJECT_SOURCE_DIR}/include | ||
| ${PROJECT_BINARY_DIR}/include | ||
| ${COIN_TARGET_INCLUDE_DIRECTORIES}) |
Collaborator
Author
There was a problem hiding this comment.
Fixed by using the shared coin_add_gl_test() helper.
| static SbString | ||
| soshaderobject_inline_source_preview(const SbString & source) | ||
| { | ||
| const char * cursor = source.getString(); |
Member
There was a problem hiding this comment.
working with std::string/std::string_view could be cleaner
Collaborator
Author
There was a problem hiding this comment.
Coin is limited just to C++11 for now, I'd rather not bump it for now just for std::string_view here.
| result += sourceDescription; | ||
| if (result.getLength() > 256) { | ||
| result = result.getSubString(0, 252); | ||
| result += "..."; |
Member
There was a problem hiding this comment.
will result be null-terminated here? 252+3=255 so \0 will be on position 256?
Collaborator
Author
There was a problem hiding this comment.
SbString::getSubString() creates an owned, null-terminated string, and appending "..." preserves that termination. I replaced the unexplained indices with named length calculations so it is clear the final description is exactly capped at 256 characters, excluding the terminator.
tritao
force-pushed
the
stack/shader-diagnostics
branch
2 times, most recently
from
August 19, 2026 10:28
eec0967 to
5a82619
Compare
Collaborator
Author
|
All should be addressed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve GLSL failure reporting without changing shader execution semantics.
This layer is diagnostic only; profile-neutral GLSL dispatch and shared core GL test support remain owned by PR #65.
Stack
Layer 4/18, based on PR #65.