Skip to content

Align extensions v2 with the manifest contract - #294

Merged
admdly merged 5 commits into
mainfrom
codex/align-extension-manifests
Nov 4, 2026
Merged

admdly merged 5 commits into
mainfrom
codex/align-extension-manifests

Conversation

@admdly

@admdly admdly commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

The extensions v2 contract currently translates package manifests into different field names and loses PHP/module constraints. Adopt manifest v1 fields directly: module, string licenses, homepage_url, package authors/icons, and full requirements for the current version and each release.

Coordinated PRs:

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-04T02:57:33.380562Z f0b0512 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
api 905d400 Nov 04 2026, 03:44 AM

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 34 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread src/services/extensions/v1/database.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 11 files (changes from recent commits).

Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.

Turn on auto-fix | Re-trigger cubic

Comment thread src/services/extensions/v2/README.md Resolved
Comment thread src/services/extensions/v1/database.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 14 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Turn on auto-fix | Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Requires human review: Aligns extensions v2 to manifest v1: new manifest column, migration 0029 with preflight/manual data correction, API field renames, v1 adapter and revalidation updates. Decisive factor: operator-reviewed legacy data corrections and coordinated public-contract rollout.

Turn on auto-fix | Re-trigger cubic

@admdly
admdly merged commit b8c22d6 into main Nov 4, 2026
9 checks passed
@admdly
admdly deleted the codex/align-extension-manifests branch November 4, 2026 03:49
admdly added a commit to FOSSBilling/modules that referenced this pull request Nov 4, 2026
The publisher currently converts `module` to `mod`, converts licenses to
objects, drops author/PHP/module metadata, and reduces FOSSBilling
requirements to a single minimum. Send manifest v1 fields directly,
including optional homepage/icon paths and complete requirements on each
release.

Preserve historical release constraints and idempotent same-version
replacement. Refuse API history without manifest requirements so
publishing against an unmigrated API cannot silently discard

Coordinated PRs:

- [FOSSBilling/api #294](FOSSBilling/api#294)
- [FOSSBilling/extensions
#406](FOSSBilling/extensions#406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant