Skip to content

Build tagged releases and preserve publisher history - #10

Merged
admdly merged 3 commits into
mainfrom
codex/fix-publisher-api-contract
Nov 4, 2026
Merged

admdly merged 3 commits into
mainfrom
codex/fix-publisher-api-contract

Conversation

@admdly

@admdly admdly commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Manual publishing currently reads package files from the selected workflow branch. Check out the requested release tag separately and use its package files with the reviewed publisher tooling. Resolve tags with the manifest semver grammar so prereleases containing -v are preserved and tag values reach the shell through environment variables.

A public 404 can hide a delisted or unpublished extension. The old create-conflict fallback could update that record with an empty release history. Record whether the payload's history read found the extension, use that same result for POST/PUT, and stop conflicting creates for manual correction.

Enforce the API's 100,000 UTF-16-unit README limit and serialize compact UTF-8 JSON so valid Unicode content is measured against the 256 KiB cap correctly. The merged API still returns pending submissions and permits explicit approval by a mapped publisher with publish rights; that flow is retained.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T04:39:53.529505Z 5deaf01 Manual request
🔒 Security Review ✅ Completed 2026-11-04T04:24:44.011049Z dc8b2e2 PR opened

Security findings

Advisory findings (1)

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@admdly admdly self-assigned this Nov 4, 2026
@admdly

This comment was marked as low quality.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️ Codex Security Review · Automatically triggered

Here are some automated security review suggestions for this pull request.

Reviewed commit: dc8b2e2447

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Comment thread .github/workflows/publish.yml Resolved
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: dc8b2e2447

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@admdly

This comment was marked as low quality.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a89306646

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/publish.yml Resolved
@admdly

This comment was marked as low quality.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 5deaf01bf6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@admdly
admdly merged commit 5a32058 into main Nov 4, 2026
3 checks passed
@admdly
admdly deleted the codex/fix-publisher-api-contract branch November 4, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant