Repository navigation
Remove the legacy SParse JSON functions - #2810
Conversation
inimaga
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bbc2ad4a0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
inimaga
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e57c37c5e6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 participants
Held on:
https://github.com/Expensify/Auth/pull/24746https://github.com/Expensify/FuzzyBot/pull/368https://github.com/Expensify/ExpensifyBackupManager/pull/180Details
This PR removes the SParse JSON function family from libstuff and migrates the remaining Bedrock callers and tests to the shared JSON implementation. It preserves query column order and duplicate names, job metadata behavior, and HTTPS transaction defaults, with regression coverage for malformed input and embedded NUL bytes.
Fixed Issues
$https://github.com/Expensify/Expensify/issues/678222
Tests
Automated tests
Covered by added/updated automated tests
Manual tests
N/A
Query Timings/Plans
N/A