Repository navigation
Restore removal of the legacy SParse JSON functions - #2847
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6c31160ad
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
inimaga
changed the title
|
Take 2 |
tylerkaraszewski
left a comment
tylerkaraszewski
left a comment
There was a problem hiding this comment.
Please run the full Auth, FuzzyBot, and ExpensifyBackupManager tests against this, and then I'm happy to approve.
@tylerkaraszewski I ran the tests and can confirm this is good to go. |
2 participants
Held on:
Details
This PR restores Bedrock#2810, which was reverted in Bedrock#2841 after Auth tests failed on JSON key order and spacing. It removes the old JSON parsing functions and moves the remaining Bedrock callers to the shared JSON library.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/678222
Tests
Bedrock and Auth compiled successfully. The removed parser symbols are absent from the Bedrock binary. All 218 affected Auth tests passed with both current and restored Bedrock, in normal and HCTree modes. The affected Bedrock cluster fixtures passed 26 tests.
Manual tests
N/A
Query Timings/Plans
N/A