Skip to content

[No QA] Add Business Central hub section page to the help site - #105141

Merged
twisterdotcom merged 1 commit into
mainfrom
claude-businessCentralHubPage
Nov 2, 2026
Merged

twisterdotcom merged 1 commit into
mainfrom
claude-businessCentralHubPage

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

https://help.expensify.com/new-expensify/hubs/connections/business-central returns a 404, even though the three Business Central articles added in #104923 load fine.

Each connections section needs a stub page at docs/new-expensify/hubs/connections/<section>.html so Jekyll serves the section URL. createDocsRoutes.ts builds the section data from the article folders, but it does not create this page. Rillet, DualEntry, Certinia, and the other connections all have one; Business Central did not.

This PR adds business-central.html, a byte-for-byte copy of rillet.html.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/670786
PROPOSAL: #104923 (comment)

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

AI Tests: This change adds one static HTML stub, so lint, typecheck, Jest, and Storybook do not apply. The new file is byte-identical to rillet.html. I could not run ./.github/scripts/createDocsRoutes.sh in this environment, so CI's docs validation is the check for routing.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Ted Harris <twisterdotcom@users.noreply.github.com>
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://b6855e08.helpdot.pages.dev ⚡️

@twisterdotcom
twisterdotcom marked this pull request as ready for review October 27, 2026 16:45
@melvin-bot
melvin-bot Bot requested review from cretadn22 and removed request for a team October 27, 2026 16:45
@melvin-bot

melvin-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T17:04:58.574052Z 4891583 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from sobitneupane and removed request for a team October 27, 2026 16:45
@melvin-bot

melvin-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@twisterdotcom
twisterdotcom requested review from a team and removed request for cretadn22 October 27, 2026 16:45
@melvin-bot
melvin-bot Bot requested review from aimane-chnaif and removed request for a team October 27, 2026 16:45
@melvin-bot

melvin-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@twisterdotcom
twisterdotcom requested review from a team and stephanieelliott and removed request for aimane-chnaif and sobitneupane October 27, 2026 16:45
@melvin-bot
melvin-bot Bot requested review from abdulrahuman5196 and removed request for a team October 27, 2026 16:45
@melvin-bot

melvin-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@twisterdotcom

Copy link
Copy Markdown
Contributor

@codex review

@twisterdotcom

Copy link
Copy Markdown
Contributor

Looks great:
image

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 4891583878

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing a checklist on this one. LGTM

@twisterdotcom
twisterdotcom merged commit 90fb28b into main Nov 2, 2026
26 of 28 checks passed
@twisterdotcom
twisterdotcom deleted the claude-businessCentralHubPage branch November 2, 2026 13:24
@melvin-bot melvin-bot Bot added the Emergency label Nov 2, 2026
@melvin-bot

melvin-bot Bot commented Nov 2, 2026

Copy link
Copy Markdown

@twisterdotcom looks like this was merged without a test passing. These checks had not passed on 4891583 when it was merged:

  • checklist (no successful run)

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@abdulrahuman5196
abdulrahuman5196 removed their request for review November 2, 2026 17:30
@OSBotify OSBotify mentioned this pull request Nov 2, 2026
75 tasks done
@OSBotify

OSBotify commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.5.28-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.5.30-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.30-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants