Repository navigation
[No QA] Add Business Central hub section page to the help site - #105141
Conversation
Co-authored-by: Ted Harris <twisterdotcom@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://b6855e08.helpdot.pages.dev ⚡️ |
|
@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Not seeing a checklist on this one. LGTM
|
@twisterdotcom looks like this was merged without a test passing. These checks had not passed on 4891583 when it was merged:
Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.5.28-4 🚀
|
|
🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.5.30-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.5.30-0 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
https://help.expensify.com/new-expensify/hubs/connections/business-central returns a 404, even though the three Business Central articles added in #104923 load fine.
Each connections section needs a stub page at
docs/new-expensify/hubs/connections/<section>.htmlso Jekyll serves the section URL.createDocsRoutes.tsbuilds the section data from the article folders, but it does not create this page. Rillet, DualEntry, Certinia, and the other connections all have one; Business Central did not.This PR adds
business-central.html, a byte-for-byte copy ofrillet.html.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/670786
PROPOSAL: #104923 (comment)
Tests
Offline tests
QA Steps
AI Tests: This change adds one static HTML stub, so lint, typecheck, Jest, and Storybook do not apply. The new file is byte-identical to
rillet.html. I could not run./.github/scripts/createDocsRoutes.shin this environment, so CI's docs validation is the check for routing.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari