Skip to content

[No QA] Update help docs for Integrate with Microsoft Dynamics 365 (Business Central) - #104923

Merged
JmillsExpensify merged 15 commits into
mainfrom
claude-businessCentralHelpDocs
Oct 27, 2026
Merged

JmillsExpensify merged 15 commits into
mainfrom
claude-businessCentralHelpDocs

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Business Central is becoming a direct accounting connection in New Expensify (beta). The help site has no Business Central articles, and both Indirect-Accounting-Integrations.md articles still send "Microsoft Dynamics" customers to flat-file exports. This PR covers Releases 1–3 (connect and import, export, advanced) in one PR, following the Rillet pattern.

New articles (docs/articles/new-expensify/connections/business-central/)

  • Connect-to-Business-Central.md – extension prerequisite, credentials (Tenant ID, Environment name, Client ID, Client secret), company selection (Subsidiary), disconnecting, and reconnecting after an authentication error.
  • Configure-Business-Central.md – import (Chart of accounts, Items, Projects/Customers, dimensions, Taxes), export (General journal / Purchase invoices, Default company card vendor, Payment method, multiple accounts), per-card vendor (Exports to on the card details page), and advanced settings (Auto-sync, Posting mode, Auto-create employees/vendors, Export to next open period, Sync reimbursed reports, Sync Expensify Card settlements).

Updated articles

  • new-expensify/connections/Indirect-Accounting-Integrations.md and expensify-classic/connections/Indirect-Accounting-Integrations.md – add a note that Business Central has a direct integration, with a link to the Connect article. The flat-file entry stays for other Dynamics products.
  • Unlisted/Upcoming-Integrations-And-Accounting.md – remove the Business Central "upcoming" entry and keywords, so Concierge stops describing it as upcoming. Merge this PR at GA, or revert this file if it needs to merge earlier.

Notes for reviewers

  • Vendor matching isn't duplicated here. Configure-Business-Central.md links to Manage-Vendor-Matching-for-Business-Central.md from [No QA] Docs updates for E/A#101438 Add Business Central vendor matching help article. Merge that PR first or alongside this one, or the link breaks.
  • Both new articles use noindex: true / sitemap: false because the integration is beta-gated. Remove these at GA.
  • UI labels were checked against src/languages/en.ts and the Business Central pages under src/pages/workspace/accounting/businessCentral/. The app wasn't tested in a browser.
  • Please confirm these points, which aren't visible in the App code:
    • The AppSource extension's name. The article calls it "the Expensify extension".
    • That the Entra app registration is where admins get the Tenant ID, Client ID, and Client secret.
    • That the report's export message links to the record in Business Central (Release 3).
    • That Default company card vendor is required.
  • Follow-up idea: CONST.BUSINESS_CENTRAL_HELP_URL points to the generic connections hub. Once this merges, it could point to the Connect article.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/670786
PROPOSAL: N/A

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

AI Tests

  • Not run locally: createDocsRoutes.sh and cspell were blocked in this environment, so CI will be the first check. No _routes.yml change should be needed, because business-central is a section inside the existing connections hub, like rillet and dualentry.

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team October 24, 2026 05:36
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Fixed the failing spellcheck check. cspell flagged "unposted" in Configure-Business-Central.md:99. I reworded the line to "leaves it for you to post manually." This matches the article's Create only wording. Spellcheck now passes locally on all 5 changed files.

Check independent approval will pass once the PR gets a review approval. It needs no code change.


view run

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

Replaced placeholder comment with an actual screenshot of the Dynamics 365 Business Central setup fields.
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as ready for review October 26, 2026 23:42
@melvin-bot
melvin-bot Bot requested a review from flaviadefaria October 26, 2026 23:42
@melvin-bot

melvin-bot Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @JmillsExpensify

@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and shubham1206agra and removed request for a team October 26, 2026 23:42
@melvin-bot

melvin-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

@shubham1206agra @JmillsExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T23:58:03.911099Z 27dffe6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@stephanieelliott
stephanieelliott removed the request for review from huult October 27, 2026 00:16
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott changed the title [No QA] Update help docs for Integrate with Microsoft Dynamics 365 (Business Central) [No QA] [Hold on feature] Update help docs for Integrate with Microsoft Dynamics 365 (Business Central) Oct 27, 2026
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

Added a note indicating that the integration is currently in BETA and to contact account management for interest. Microsoft require the help page to be live before they complete their review, so this is a bit of cart and horsery.
@twisterdotcom twisterdotcom changed the title [No QA] [Hold on feature] Update help docs for Integrate with Microsoft Dynamics 365 (Business Central) [No QA] Update help docs for Integrate with Microsoft Dynamics 365 (Business Central) Oct 27, 2026

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set

@JmillsExpensify
JmillsExpensify merged commit abeb2e1 into main Oct 27, 2026
15 of 17 checks passed
@JmillsExpensify
JmillsExpensify deleted the claude-businessCentralHelpDocs branch October 27, 2026 12:37
@melvin-bot melvin-bot Bot added the Emergency label Oct 27, 2026
@melvin-bot

melvin-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

@JmillsExpensify looks like this was merged without a test passing. These checks had not passed on d6e1f88 when it was merged:

  • checklist (no successful run)

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@JmillsExpensify

Copy link
Copy Markdown
Contributor

I checked the wrong checklist before merging. You can see that in the history too.

@twisterdotcom

Copy link
Copy Markdown
Contributor

@MelvinBot why does nothing show at the actual URL for ...new-expensify/hubs/connections/business-central yet we have the nested docs at /business-central/Manage-Vendor-Matching-for-Business-Central, articles/new-expensify/connections/business-central/Configure-Business-Central and articles/new-expensify/connections/business-central/Connect-to-Business-Central?

@MelvinBot

Copy link
Copy Markdown
Contributor Author

This PR added the Business Central articles but not the section page that serves the hub URL. That URL returns a 404 right now.

Each connection section needs a small stub file at docs/new-expensify/hubs/connections/<name>.html. Rillet has one (rillet.html), and so do the other connections. There is no business-central.html, so the articles load but the section page does not.

Fix: add docs/new-expensify/hubs/connections/business-central.html with the same content as rillet.html:

---
layout: default
---

{% include section.html %}
Details
  • createDocsRoutes.ts builds the section data from the article folders automatically. It does not create the HTML page that Jekyll serves at the hub URL.
  • Live check: /new-expensify/hubs/connections/rillet returns 200, and /new-expensify/hubs/connections/business-central returns 404.

Reply with @MelvinBot implement this to get a follow-up PR.


view run

@twisterdotcom

Copy link
Copy Markdown
Contributor

@MelvinBot implement this

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Draft PR created: [No QA] Add Business Central hub section page to the help site

It adds docs/new-expensify/hubs/connections/business-central.html, a byte-for-byte copy of rillet.html. After it merges and deploys, /new-expensify/hubs/connections/business-central should load the section page instead of a 404.

You're the assignee. Please fill in the Tests section and mark the PR "Ready for review" when it's ready, or ask me to do that.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JmillsExpensify in version: 9.5.24-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.24-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants