Repository navigation
[No QA] Update help docs for Integrate with Microsoft Dynamics 365 (Business Central) - #104923
Conversation
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
Fixed the failing
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Replaced placeholder comment with an actual screenshot of the Dynamics 365 Business Central setup fields.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
|
@shubham1206agra @JmillsExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Added a note indicating that the integration is currently in BETA and to contact account management for interest. Microsoft require the help page to be live before they complete their review, so this is a bit of cart and horsery.
|
@JmillsExpensify looks like this was merged without a test passing. These checks had not passed on d6e1f88 when it was merged:
Please add a note explaining why this was done and remove the |
|
I checked the wrong checklist before merging. You can see that in the history too. |
|
@MelvinBot why does nothing show at the actual URL for ...new-expensify/hubs/connections/business-central yet we have the nested docs at /business-central/Manage-Vendor-Matching-for-Business-Central, articles/new-expensify/connections/business-central/Configure-Business-Central and articles/new-expensify/connections/business-central/Connect-to-Business-Central? |
|
This PR added the Business Central articles but not the section page that serves the hub URL. That URL returns a 404 right now. Each connection section needs a small stub file at Fix: add ---
layout: default
---
{% include section.html %}Details
Reply with |
|
@MelvinBot implement this |
|
🤖 Draft PR created: [No QA] Add Business Central hub section page to the help site It adds You're the assignee. Please fill in the Tests section and mark the PR "Ready for review" when it's ready, or ask me to do that. |
|
🚀 Deployed to staging by https://github.com/JmillsExpensify in version: 9.5.24-1 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.24-8 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Business Central is becoming a direct accounting connection in New Expensify (beta). The help site has no Business Central articles, and both
Indirect-Accounting-Integrations.mdarticles still send "Microsoft Dynamics" customers to flat-file exports. This PR covers Releases 1–3 (connect and import, export, advanced) in one PR, following the Rillet pattern.New articles (
docs/articles/new-expensify/connections/business-central/)Connect-to-Business-Central.md– extension prerequisite, credentials (Tenant ID, Environment name, Client ID, Client secret), company selection (Subsidiary), disconnecting, and reconnecting after an authentication error.Configure-Business-Central.md– import (Chart of accounts, Items, Projects/Customers, dimensions, Taxes), export (General journal / Purchase invoices, Default company card vendor, Payment method, multiple accounts), per-card vendor (Exports to on the card details page), and advanced settings (Auto-sync, Posting mode, Auto-create employees/vendors, Export to next open period, Sync reimbursed reports, Sync Expensify Card settlements).Updated articles
new-expensify/connections/Indirect-Accounting-Integrations.mdandexpensify-classic/connections/Indirect-Accounting-Integrations.md– add a note that Business Central has a direct integration, with a link to the Connect article. The flat-file entry stays for other Dynamics products.Unlisted/Upcoming-Integrations-And-Accounting.md– remove the Business Central "upcoming" entry and keywords, so Concierge stops describing it as upcoming. Merge this PR at GA, or revert this file if it needs to merge earlier.Notes for reviewers
Configure-Business-Central.mdlinks toManage-Vendor-Matching-for-Business-Central.mdfrom [No QA] Docs updates for E/A#101438 Add Business Central vendor matching help article. Merge that PR first or alongside this one, or the link breaks.noindex: true/sitemap: falsebecause the integration is beta-gated. Remove these at GA.src/languages/en.tsand the Business Central pages undersrc/pages/workspace/accounting/businessCentral/. The app wasn't tested in a browser.CONST.BUSINESS_CENTRAL_HELP_URLpoints to the generic connections hub. Once this merges, it could point to the Connect article.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/670786
PROPOSAL: N/A
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
AI Tests
createDocsRoutes.shandcspellwere blocked in this environment, so CI will be the first check. No_routes.ymlchange should be needed, becausebusiness-centralis a section inside the existingconnectionshub, likerilletanddualentry.