Repository navigation
[No QA] Docs updates for E/A#103549 Remove read-only vendor list wording, add disable step - #104888
Conversation
Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
MelvinBot
added
the
HelpDot
github-actions
Bot
changed the title
|
@MelvinBot Mark this as ready |
|
I marked this PR as ready for review. |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? cc @heyjennahay |
|
@heyjennahay Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 793af67e1d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 3. Use **Find vendor** to search the list by name. | ||
|
|
||
| Vendors are managed in Campfire, so the list is read-only in Expensify and refreshes when the connection syncs. | ||
| Vendors are managed in Campfire, and the list refreshes when the connection syncs. To stop a vendor from appearing in the **Vendor** field on expenses, disable it in the **Enabled** column. |
There was a problem hiding this comment.
When the vendor is currently configured as the workspace's default, this instruction cannot be followed because WorkspaceVendorsPage locks its Enabled toggle and excludes it from bulk disable actions. The same omission appears in all four changed articles, so users must first change or clear the default vendor in the accounting export settings; document that prerequisite rather than directing them to a disabled control.
Useful? React with 👍 / 👎.
HelpDot Documentation ReviewOverall AssessmentThis PR updates the vendor-matching articles for Campfire, DualEntry, Intuit Enterprise Suite, and Rillet. The same single-sentence change is applied identically to all four files: it removes the outdated "the list is read-only in Expensify" claim and adds guidance that admins can disable an imported vendor in the Enabled column to stop it appearing in the Vendor field. The change is an accuracy fix reflecting PR 103549, and it is small, consistent, and well scoped. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.21-0 🚀
|
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.23-0 🚀
|
Explanation of Change
Add imported vendor enable and disable controls added an Enabled column to Workspaces > [workspace name] > Vendors. Workspace admins can now disable imported vendors so they no longer appear in the Vendor field on expenses.
This made the following sentence incorrect in the vendor matching articles for DualEntry, Campfire, Rillet, and Intuit Enterprise Suite:
The list is no longer read-only. Each sentence now says the list refreshes on sync and that admins can disable a vendor in the Enabled column to hide it from the Vendor field.
The Certinia article has the same sentence, but Certinia vendor matching is still behind the
vendorMatchingbeta, so it is left unchanged. The QuickBooks Online, Sage Intacct, and Xero articles don't describe the vendor list as read-only, so they need no change.The Enabled column label comes from
common.enabledinsrc/languages/en.ts.@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #98355
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari