Repository navigation
[Hold on feature] Docs updates for E/A#102933 Add Approve-only role to workspace members article - #104886
Conversation
Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
MelvinBot
added
the
HelpDot
|
@MelvinBot Mark this as ready |
|
🤖 This PR is now marked as ready for review. |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@dylanexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - **Workspace admin** – Can manage members, roles, workflows, and settings. | ||
| - **Card admin** – Can manage the Expensify Card and Company cards, including issuing cards, setting limits, and assigning company cards. Has read-only access to Overview and Members, and all other workspace settings pages are hidden. (Control workspaces only) | ||
| - **People admin** – Can manage workspace membership and configure approval workflows. People admins can add and remove Members, Guests, and Auditors only, and cannot add or remove admins or other scoped admin roles. They have read-only access to the workspace overview and edit access to Members and the Approvals section of Workflows. All other workspace editor pages are hidden. (Control workspaces only) | ||
| - **People admin** – Can manage workspace membership and configure approval workflows. People admins can add and remove Members, Guests, Auditors, and Approve-only members only, and cannot add or remove admins or other scoped admin roles. They have read-only access to the workspace overview and edit access to Members and the Approvals section of Workflows. All other workspace editor pages are hidden. (Control workspaces only) |
There was a problem hiding this comment.
Readability: "Auditors, and Approve-only members only" places "members only" directly after the "Approve-only" label, which reads ambiguously (as if "Approve-only members only" were one phrase). Reword for clarity, e.g. "...can only add and remove Members, Guests, Auditors, and Approve-only members, and cannot add or remove admins or other scoped admin roles."
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, focused update to Managing Workspace Members in New Expensify (/articles/new-expensify/workspaces/Managing-Workspace-Members) to document the new Approve-only workspace role on Control workspaces (+7 / -5). The changes add the role to the keyword list, add a new role definition bullet, add it to the role filter list, and correct four People admin permission sentences that were previously inaccurate. The additions are accurate, consistent, and verified against the live web UI. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is an automated governance-based review. Scores are derived from docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md. |
stephanieelliott
changed the title
|
Moving this to |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.24-1 🚀
|
|
@ShridharGoel No QA steps, OK to checkoff? |
Explanation of Change
[Payment due
@Pujan92] Add approve-only workspace role added a new Approve-only workspace role on Control workspaces. People admins can assign it, and it appears as a role filter on the Members page. This PR updates Managing Workspace Members in New Expensify.New feature: the Approve-only role. It's added to the role list and the role filter list.
Sentences that are now incorrect: People admins can now invite, remove, and assign Approve-only members, so these sentences are now wrong:
Each sentence now includes Approve-only. The role and filter labels were checked against the live web UI.
Live UI verification (web)
Role list: Workspace admin, Auditor, Guest, Card admin, People admin, Payments admin, Member, Approve-only ("Approve reports only.")
Role filters: Workspace Admins, Approvers, Card Admins, People Admins, Payments Admins, Auditors, Guests, Approve-only, Members
@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #102933
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari