[MelvinBot]

Explanation of Change

Show Cash accruals and Bank reconciliation to Payments Admins gives the Payments admin role the Cash accruals and Bank reconciliation shortcuts in the Accounting section of Spend. Two help articles said only other roles could use them:

• Accounting Search Shortcuts, under "Who can use Accounting search shortcuts": "Workspace admins and auditors with: …" This PR adds: "Payments admins can use the Cash accruals and Bank reconciliation shortcuts."
• Reconcile Reimbursements: "Workspace Admins can use the Bank reconciliation report to reconcile reimbursements when Payments is enabled on the Workspace with a verified business bank account." This PR changes it to "Workspace admins and payments admins can use…"

The internalScope metadata of both articles now lists payments admins in the audience. Card accruals, Card statements, and Expensify Card reconciliation stay limited to workspace admins and auditors, so those sentences don't change. UI labels were checked against src/languages/en.ts.

@flodnv, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #104783
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

Product reviewer checklist:

• I have verified the accuracy of the article
  • The article is within a hub that makes sense, and the navigation is correct
  • All processes, screenshots, and examples align with current product behavior.
  • All links within the doc have been verified for correct destination and functionality.
• I have verified the readability of the article
  • The article's language is clear, concise, and free of jargon.
  • The grammar, spelling, and punctuation are correct.
  • The article contains at least one image, or that an image is not necessary
• I have verified the formatting of the article
  • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
  • The article has proper text spacing and breaks for readability.
• I have verified the article has the appropriate tone and style
  • The article's tone is professional, friendly, and suitable for the target audience.
  • The article's tone, terminology, and voice are consistent throughout.
• I have verified the overall quality of the article
  • The article is not missing any information, nor does it contain redundant information.
  • The article fully addresses user needs.
• I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @heyjennahay

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-27T15:55:17.012900Z	f214b1d	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[melvin-bot]

@heyjennahay Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

Role naming violation: "Payments admins" is not an approved role name. Per HELPSITE_NAMING_CONVENTIONS.md (Roles), the valid role names are workspace admin, workspace owner, domain admin, account manager, account executive, partner manager, and member. Use one of these approved roles (or describe the capability by permission, e.g. "Admins with Payments enabled") rather than inventing a "payments admin" role.

[github-actions]

Role naming violation: "payments admins" is not an approved role name. Per HELPSITE_NAMING_CONVENTIONS.md (Roles), the valid roles are workspace admin, workspace owner, domain admin, account manager, account executive, partner manager, and member. Replace "payments admins" with an approved role or describe the capability by permission (e.g. workspace admins with Payments enabled).

[flodnv]

@MelvinBot submit a PR to update HELPSITE_NAMING_CONVENTIONS Roles with all of the available workspace roles (payments admins, card admins, etc)

[github-actions]

HelpDot Documentation Review

Overall Assessment
This PR makes a small, targeted accuracy update to two existing HelpDot articles to reflect that the payments admin role can now use the Cash accruals and Bank reconciliation shortcuts (per Expensify/App PR 104783). Changes are limited to internalScope metadata and one or two sentences per file. The edits are precise, scoped, and align with the governance standards. No structural, heading, or new-content concerns.

Scores Summary

• Readability: 9/10 - Added sentences are clear, concise, and scannable; UI labels are bolded appropriately.
• AI Readiness: 9/10 - internalScope metadata was correctly expanded to include the new audience (payments admins), keeping retrieval metadata accurate. Full feature names (Cash accruals, Bank reconciliation) are used verbatim.
• Style Compliance: 9/10 - Role and generic-term casing was improved to match HELPSITE_NAMING_CONVENTIONS.md.

Key Findings

• Role casing corrected: "Workspace Admins" to "workspace admins" and "Workspace" to "workspace" in Reconcile-Reimbursements.md now follow the lowercase-roles / lowercase-generic-terms rules, fixing a pre-existing style issue.
• UI labels Cash accruals and Bank reconciliation are bolded and match src/languages/en.ts casing.
• internalScope metadata on both files was updated in lockstep with the body copy, keeping audience scope accurate for AI retrieval.
• Correctly scoped: Card accruals, Card statements, and Expensify Card reconciliation were intentionally left unchanged, matching the underlying feature behavior.
• Minor nit: the new sentence in Accounting-Search-Shortcuts.md capitalizes "Payments" only because it starts the sentence, which is acceptable. No change required.

Recommendations

• No blocking issues. The changes are accurate and compliant.
• Optional: confirm the new sentence in Accounting-Search-Shortcuts.md reads clearly as an audience qualifier within the "Who can use" section.

Files Reviewed

• docs/articles/new-expensify/reports-and-expenses/Accounting-Search-Shortcuts.md - Pass. internalScope expanded; one sentence added with correctly bolded UI labels.
• docs/articles/new-expensify/reports-and-expenses/Reconcile-Reimbursements.md - Pass. internalScope and body updated; role/generic-term casing improved to meet conventions.

Note: These are low-risk documentation accuracy updates that improve both correctness and style compliance.

[JmillsExpensify]

@MelvinBot give me a checklist as reviewer

[MelvinBot]

Here's your reviewer checklist. The changes match the merged code in Show Cash accruals and Bank reconciliation to Payments Admins, with two small gaps to decide on (items 4 and 5).

Accuracy (checked against SearchUIUtils.ts:772-830)

• 1. Payments admins get Cash accruals and Bank reconciliation only. They don't get Card accruals, Card statements, or Expensify Card reconciliation. ✅ Matches the code.
• 2. The new sentence at Accounting-Search-Shortcuts.md:22 lists no conditions. In code, Cash accruals still needs approvals and reimbursements turned on. Bank reconciliation needs reimbursements, a verified business bank account, and a reimburser. Decide whether the FAQ at line 61 already covers this.
• 3. Reconcile-Reimbursements.md:16 says "Workspace admins and payments admins… with a verified business bank account." ✅ Matches the code.

Possible gaps

• 4. The intro at Accounting-Search-Shortcuts.md:12 still says only "Workspace admins and auditors can use these shortcuts."
• 5. Line 43 says Bank reconciliation shows reimbursements and Expensify Card settlements. Payments admins see the reimbursement view only.

Readability and formatting

• 6. The role is written as "payments admins" in lowercase, which matches "workspace admins."
• 7. The internalScope front matter in both files names payments admins. No headings, links, or images changed.

Process

• 8. Complete the product reviewer checklist in the first melvin-bot comment.
• 9. Leave the Tests and QA sections as they are. This is a docs-only PR.

---

view run

[JmillsExpensify]

Alright, melvin. I completed the checkboxes you created for me and then also the ones for Jenna. I guess that's what you wanted 🤷🏼

[JmillsExpensify]

LGTM. I think the accounting shortcuts call out is fine, as it mentions payment admins.

[OSBotify]

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.24-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

[m-natarajan]

@flodnv No QA steps, OK to checkoff?

[flodnv]

No QA

[MelvinBot]

🤖 I opened a draft PR: Docs: List all workspace roles in HELPSITE_NAMING_CONVENTIONS

It splits the Roles list into two parts:

• Workspace role names: workspace owner, workspace admin, auditor, card admin, people admin, payments admin, member, approve-only member, and guest.
• Other role names: domain admin, account manager, account executive, and partner manager. These are unchanged.

The workspace roles match the member role picker in WorkspaceMemberRoleList.tsx, plus the owner. I left out the internal editor role because the role picker doesn't offer it. I also added correct and incorrect examples for card admin and payments admin.

I couldn't run cspell or prettier here, so CI will be the first check for those.

Please review the change. Then comment @MelvinBot mark this PR as ready for review.

---

view run

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.24-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS