Skip to content

Show Cash accruals and Bank reconciliation to Payments Admins - #104783

Merged
flodnv merged 1 commit into
mainfrom
flodnv-paymentsAdminAccountingSearches
Oct 23, 2026
Merged

flodnv merged 1 commit into
mainfrom
flodnv-paymentsAdminAccountingSearches

Conversation

@flodnv

@flodnv flodnv commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Payments Admins now see two searches in the Accounting section of Spend: Cash accruals and Bank reconciliation. Each workspace still needs to meet the existing conditions for these searches. For example, Bank reconciliation needs payments turned on and an open business bank account with a reimburser.

Card accruals, Card statements, and the Expensify Card version of Bank reconciliation stay limited to Admins and Auditors. Because a Payments Admin never turns on the Expensify Card search, Bank reconciliation opens with Withdrawal type: Reimbursement for them. If someone is an Admin on a workspace with Expensify Cards and a Payments Admin on another, it opens on Expensify Card, as it does today for Admins. The filter stays editable.

Auth already shares every workspace report with Payments Admins at read and sends them the workspace bank account details, so this PR needs no backend change.

Fixed Issues

For https://github.com/Expensify/Expensify/issues/680662

Tests

Setup: create three Control workspaces, each with approvals on.

  • Workspace A: User C is the Admin, and Expensify Cards are on.
  • Workspace B: ACH payments use an open business bank account with a reimburser, and Expensify Cards are on. User A and User C are Payments Admins. A member has four reimbursable expenses: one paid by ACH last month, one approved, one awaiting approval, and one draft.
  • Workspace C: payments are manual and there's no bank account. User B is a Payments Admin. A member has one submitted reimbursable expense.

Payments Admin with a bank account:

  1. Sign in as User A.
  2. Go to Spend and confirm you see all four of workspace B's expenses under Expenses.
  3. Confirm the Accounting section shows Cash accruals and Bank reconciliation, and doesn't show Card accruals or Card statements.
  4. Open Cash accruals and confirm it groups the draft and the expense awaiting approval under the member.
  5. Open Bank reconciliation and confirm it opens with Withdrawal type: Reimbursement and Withdrawn: Last month, and lists the ACH withdrawal with the paid expense.

Payments Admin without a bank account:

  1. Sign in as User B.
  2. Go to Spend and confirm you see workspace C's submitted expense under Expenses.
  3. Confirm the Accounting section shows Cash accruals and doesn't show Bank reconciliation.
  4. Open Cash accruals and confirm it lists the submitted expense.

Admin on one workspace and Payments Admin on another:

  1. Sign in as User C.
  2. Go to Spend and confirm the Accounting section shows Cash accruals and Bank reconciliation.
  3. Open Bank reconciliation and confirm it opens with Withdrawal type: Expensify Card, because User C is an Admin on workspace A, which has Expensify Cards.
  4. Change Withdrawal type to Reimbursement and confirm workspace B's ACH withdrawal shows.
  • Verify that no errors appear in the JS console

Offline tests

  1. Sign in as User A and go to Spend.
  2. Turn off your network connection.
  3. Confirm Cash accruals and Bank reconciliation still show in the Accounting section, because they depend only on workspace data that's already loaded.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Payments Admin with a bank account: Expenses

1

Payments Admin with a bank account: Cash accruals

2

Payments Admin with a bank account: Bank reconciliation on Reimbursement

3

Payments Admin without a bank account: Expenses

4

Payments Admin without a bank account: Cash accruals, no Bank reconciliation

5

Admin on one workspace and Payments Admin on another: Expenses

6

Admin on one workspace and Payments Admin on another: Bank reconciliation opens on Expensify Card

7

Admin on one workspace and Payments Admin on another: Bank reconciliation switched to Reimbursement

8

@flodnv
flodnv requested review from a team as code owners October 22, 2026 18:12
@melvin-bot
melvin-bot Bot requested review from dylanexpensify and removed request for a team October 22, 2026 18:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T18:16:27.471925Z 5a09f4d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from pecanoro and removed request for a team October 22, 2026 18:13
@melvin-bot

melvin-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

@pecanoro Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a09f4db31

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/SearchUIUtils.ts Resolved
@flodnv
flodnv requested review from JmillsExpensify and removed request for dylanexpensify October 22, 2026 18:21
@pecanoro

pecanoro commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@flodnv
flodnv merged commit 304a142 into main Oct 23, 2026
48 of 53 checks passed
@flodnv
flodnv deleted the flodnv-paymentsAdminAccountingSearches branch October 23, 2026 15:24
@github-actions

Copy link
Copy Markdown
Contributor

🚧 flodnv has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

This comment has been minimized.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/flodnv in version: 9.5.20-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

A help site update is needed. I opened Docs updates for E/A#104783 Payments admins can use Cash accruals and Bank reconciliation.

This PR gives payments admins the Cash accruals and Bank reconciliation shortcuts without a beta gate. Two "who can" sentences left them out:

  • Accounting Search Shortcuts: "Workspace admins and auditors with: …" The docs PR adds one sentence saying payments admins can use these two shortcuts.
  • Reconcile Reimbursements: "Workspace Admins can use the Bank reconciliation report…" The docs PR changes it to "Workspace admins and payments admins can use…"

@flodnv, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run

@github-actions

Copy link
Copy Markdown
Contributor

🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104783.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://104783.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@JmillsExpensify

Copy link
Copy Markdown
Contributor

Ah didn't realize that this was already merged. All good, the tests look really good to me.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.20-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants