Repository navigation
Show Cash accruals and Bank reconciliation to Payments Admins - #104783
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a09f4db31
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 flodnv has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This comment has been minimized.
This comment has been minimized.
|
🚀 Deployed to staging by https://github.com/flodnv in version: 9.5.20-0 🚀
|
|
A help site update is needed. I opened Docs updates for E/A#104783 Payments admins can use Cash accruals and Bank reconciliation. This PR gives payments admins the Cash accruals and Bank reconciliation shortcuts without a beta gate. Two "who can" sentences left them out:
@flodnv, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Ah didn't realize that this was already merged. All good, the tests look really good to me. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.20-5 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Payments Admins now see two searches in the
Accountingsection ofSpend:Cash accrualsandBank reconciliation. Each workspace still needs to meet the existing conditions for these searches. For example,Bank reconciliationneeds payments turned on and an open business bank account with a reimburser.Card accruals,Card statements, and the Expensify Card version ofBank reconciliationstay limited to Admins and Auditors. Because a Payments Admin never turns on the Expensify Card search,Bank reconciliationopens withWithdrawal type: Reimbursementfor them. If someone is an Admin on a workspace with Expensify Cards and a Payments Admin on another, it opens onExpensify Card, as it does today for Admins. The filter stays editable.Auth already shares every workspace report with Payments Admins at
readand sends them the workspace bank account details, so this PR needs no backend change.Fixed Issues
For https://github.com/Expensify/Expensify/issues/680662
Tests
Setup: create three Control workspaces, each with approvals on.
Payments Admin with a bank account:
Spendand confirm you see all four of workspace B's expenses underExpenses.Accountingsection showsCash accrualsandBank reconciliation, and doesn't showCard accrualsorCard statements.Cash accrualsand confirm it groups the draft and the expense awaiting approval under the member.Bank reconciliationand confirm it opens withWithdrawal type: ReimbursementandWithdrawn: Last month, and lists the ACH withdrawal with the paid expense.Payments Admin without a bank account:
Spendand confirm you see workspace C's submitted expense underExpenses.Accountingsection showsCash accrualsand doesn't showBank reconciliation.Cash accrualsand confirm it lists the submitted expense.Admin on one workspace and Payments Admin on another:
Spendand confirm theAccountingsection showsCash accrualsandBank reconciliation.Bank reconciliationand confirm it opens withWithdrawal type: Expensify Card, because User C is an Admin on workspace A, which has Expensify Cards.Withdrawal typetoReimbursementand confirm workspace B's ACH withdrawal shows.Offline tests
Spend.Cash accrualsandBank reconciliationstill show in theAccountingsection, because they depend only on workspace data that's already loaded.QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Payments Admin with a bank account:
ExpensesPayments Admin with a bank account:
Cash accrualsPayments Admin with a bank account:
Bank reconciliationonReimbursementPayments Admin without a bank account:
ExpensesPayments Admin without a bank account:
Cash accruals, noBank reconciliationAdmin on one workspace and Payments Admin on another:
ExpensesAdmin on one workspace and Payments Admin on another:
Bank reconciliationopens onExpensify CardAdmin on one workspace and Payments Admin on another:
Bank reconciliationswitched toReimbursement