Skip to content

[No QA] Docs updates for E/A#101686 Add Save step to reassigning a task - #104881

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsTaskAssigneeSave
Oct 28, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsTaskAssigneeSave

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

After #101686, selecting a new assignee while editing an existing task no longer reassigns it right away. The change only applies after you select Save.

This sentence in Assign a Task via Chat described the old select-to-apply behavior:

Reassign the task by clicking the task, then clicking the arrow next to the Assignee field, and selecting a new person or entering their email.

A reader following it would stop before the task was reassigned. The sentence now ends with "and then selecting Save." The Create a Task steps are unchanged because the new-task flow still applies the assignee on selection.

@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #101686
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: truph01 <truph01@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 23, 2026
@MelvinBot
MelvinBot requested a review from a team October 23, 2026 17:16
@github-actions github-actions Bot changed the title Docs updates for E/A#101686 Add Save step to reassigning a task [No QA] Docs updates for E/A#101686 Add Save step to reassigning a task Oct 23, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://31a47bb9.helpdot.pages.dev ⚡️

Updated articles:

@truph01

truph01 commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Mark this PR as ready

@MelvinBot
MelvinBot marked this pull request as ready for review October 28, 2026 02:27
@MelvinBot

Copy link
Copy Markdown
Contributor Author

✅ This PR is now marked as ready for review.


view run

@melvin-bot

melvin-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @joekaufmanexpensify

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T02:32:35.114521Z 505bd8e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team October 28, 2026 02:28
@melvin-bot

melvin-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

@joekaufmanexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR makes a single, targeted copy fix to docs/articles/new-expensify/chat/Assign-Tasks.md. It appends an "and then selecting Save" clause to the task reassignment bullet so the instruction reflects the new behavior from PR 101686, where selecting a new assignee no longer applies immediately. The change is small, accurate, and correctly scoped to the behavior it documents.

Scores Summary

  • Readability: 9/10 - The added clause reads clearly and keeps the bullet parallel structure. The sentence is now slightly long, but the sequencing remains easy to follow.
  • AI Readiness: 9/10 - No metadata, headings, or structure were touched. The added text uses the full, explicit action and matches real user search intent for completing a reassignment. No regressions to retrieval quality.
  • Style Compliance: 8/10 - The added phrase is fully compliant: the select verb is used for the UI action and the Save button name is bolded and matches the UI exactly, per HELPSITE_NAMING_CONVENTIONS.md.

Key Findings

  • Positive: The core fix is correct and necessary. Prior to this, a reader following the steps would stop before the reassignment was actually applied.
  • Positive: The added select Save clause follows the naming conventions exactly (select verb, bold button name, no quotation marks, exact UI casing).
  • Observation (out of scope): The surrounding sentence still uses clicking the task and clicking the arrow, which the conventions prohibit in favor of select. These words are pre-existing and not part of this diff, so they do not affect the score. They could optionally be corrected in a follow-up for consistency.

Recommendations

  • No blocking issues. The change is ready from a documentation-quality standpoint.
  • Optional: Consider replacing the remaining clicking instances in this same bullet with select to bring the full sentence into compliance while it is already being edited.
  • Reminder: The PR template Tests and QA sections still contain TODO placeholders that the human co-author needs to complete before marking ready for review.

Files Reviewed

  • docs/articles/new-expensify/chat/Assign-Tasks.md - Accurate, compliant one-line fix. Approved with an optional consistency suggestion.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott merged commit 6abcbc5 into main Oct 28, 2026
24 of 26 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsTaskAssigneeSave branch October 28, 2026 02:55
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.25-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.25-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants