fix: Members show Owner as a badge next to name instead in Role column by paulnjs · Pull Request #104830 · Expensify/App

paulnjs · 2026-10-23T09:54:03Z

Explanation of Change

WorkspaceMembersPage.tsx: ownerDisplayRole swaps the owner's role for CONST.POLICY.ROLE.OWNER. Use the employee's role here instead, and pass a flag for the badge.
WorkspaceMembersTableRow.tsx: render the badge next to the name.
WorkspaceTableRow.tsx: DefaultWorkspaceBadge is the pattern to match.
Sorting by Role puts the owner with the other workspace admins after this change.

Fixed Issues

$#104754
PROPOSAL:

Tests

Open app
Log in and create a workspace.
Go to Members.
Look at the member list
Verify:

Role column shows the member's real role. For the owner of a Collect or Control workspace, that is Workspace admin, the same as the member details page.
Show an Owner badge inline, right after the owner's name in the Member column. Use the same badge style as the Default badge in the Workspaces list.
On narrow layouts, the subtitle shows the real role (Workspace admin • email), and the badge sits next to the name in its condensed style.
Verify that no errors appear in the JS console

Offline tests

QA Steps

Open app
Log in and create a workspace.
Go to Members.
Look at the member list
Verify:

Role column shows the member's real role. For the owner of a Collect or Control workspace, that is Workspace admin, the same as the member details page.
Show an Owner badge inline, right after the owner's name in the Member column. Use the same badge style as the Default badge in the Workspaces list.
On narrow layouts, the subtitle shows the real role (Workspace admin • email), and the badge sits next to the name in its condensed style.
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-10-23T09:54:10Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-23T09:54:12Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-23T10:19:38.820438Z	`9a0a1db`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

codecov · 2026-10-23T09:57:43Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`95.90% <ø> (ø)`
src/components/Tables/WorkspaceListTable/index.tsx	`79.01% <100.00%> (ø)`
...WorkspaceMembersTable/WorkspaceMembersTableRow.tsx	`100.00% <100.00%> (ø)`
.../components/Tables/WorkspaceMembersTable/index.tsx	`85.71% <100.00%> (+16.59%)`	⬆️
src/pages/workspace/WorkspaceMembersPage.tsx	`79.08% <100.00%> (-0.06%)`	⬇️
... and 7 files with indirect coverage changes

JmillsExpensify

Participated in the related Slack thread. Product approved.

bernhardoj · 2026-10-24T16:36:50Z

Since the role owner is not valid, should we remove it from the app? This is the last usage (other than the language translations).

App/src/components/Tables/WorkspaceListTable/index.tsx

Line 130 in c08c85f

    
           const canAccessArchived = (role: ValueOf<typeof CONST.POLICY.ROLE>) => role === CONST.POLICY.ROLE.ADMIN || role === CONST.POLICY.ROLE.OWNER || role === CONST.POLICY.ROLE.AUDITOR;

bernhardoj · 2026-10-24T16:37:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-10-26T05:18:06Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

These compiled action files were regenerated during a main merge and are not part of the members Owner badge fix. Co-authored-by: Cursor <cursoragent@cursor.com>

paulnjs · 2026-10-26T05:26:54Z

@bernhardoj Yes, owner isn't a valid policy role. Ownership is policy.owner / ownerAccountID, and the last product use was the archived-workspace check, which still works for owners through admin.

Removed CONST.POLICY.ROLE.OWNER and the leftover roleName translations.

bernhardoj · 2026-10-27T02:54:27Z

@paulnjs there is a conflict

bernhardoj · 2026-10-29T03:16:40Z

@paulnjs there are failing tests

paulnjs · 2026-10-29T03:18:12Z

there are failing tests

I'm checking it

paulnjs · 2026-10-29T03:32:48Z

Updated

bernhardoj · 2026-10-29T15:44:24Z

@paulnjs hmm, another flaky reassure failure

paulnjs · 2026-10-29T16:29:12Z

@bernhardoj I think it's from main. Merge latest main resolved it.

bernhardoj · 2026-10-30T00:35:33Z

@mountiny ready for you

mountiny

Thanks

github-actions · 2026-11-02T02:26:25Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-11-02T02:29:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-11-02T02:31:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104830 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6712f6fa-f89e1f8-a02a25b2ef4857bcdbf865d328187eee84419a7a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6712f6fa-f89e1f8-b3153120339c6d47d6f6786ac86fa7ee9b0456a7/index.html

Web 🕸️
https://104830.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-11-02T18:52:26Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.28-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-11-02T18:56:29Z

No help site update needed. This PR moves the owner label from the Role column to a badge next to the owner's name, and no article says the owner's role appears as "Owner." The existing step in Managing Workspace Members, "Click the current Owner (identified with a tag)," is still accurate.

view run

OSBotify · 2026-11-03T17:57:30Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-11-03T19:03:23Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

fix: Members show Owner as a badge next to name instead in Role column

b967618

paulnjs requested review from a team as code owners October 23, 2026 09:54

melvin-bot Bot assigned paulnjs Oct 23, 2026

melvin-bot Bot requested review from bernhardoj and removed request for a team October 23, 2026 09:54

melvin-bot Bot requested review from JmillsExpensify and removed request for a team October 23, 2026 09:54

paulnjs marked this pull request as draft October 23, 2026 09:54

github-actions Bot reviewed Oct 23, 2026

View reviewed changes

Comment thread src/components/Tables/WorkspaceMembersTable/index.tsx Resolved

update code

9a0a1db

paulnjs marked this pull request as ready for review October 23, 2026 10:06

JmillsExpensify previously approved these changes Oct 23, 2026

View reviewed changes

paulnjs added 2 commits October 26, 2026 12:09

Merge branch 'main' into paulnjs-fix/104754

10b9917

remove owner role and related translations

e573391

paulnjs dismissed JmillsExpensify’s stale review via e573391 October 26, 2026 05:18

Revert unrelated GitHub Action bundle changes.

1228100

These compiled action files were regenerated during a main merge and are not part of the members Owner badge fix. Co-authored-by: Cursor <cursoragent@cursor.com>

paulnjs added 2 commits October 27, 2026 10:02

Merge branch 'main' into paulnjs-fix/104754

c5a1843

update code

022ba08

bernhardoj approved these changes Oct 27, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny October 27, 2026 03:08

Merge branch 'main' into paulnjs-fix/104754

c7ddbd4

update test

5c1b3e3

MelvinBot mentioned this pull request Oct 29, 2026

Show the full report field name in a tooltip when it is cut off #105279

Merged

36 of 38 tasks

Merge branch 'main' into paulnjs-fix/104754

ab4d41f

mountiny approved these changes Nov 2, 2026

View reviewed changes

mountiny merged commit 6712f6f into Expensify:main Nov 2, 2026
38 of 39 checks passed

OSBotify mentioned this pull request Nov 2, 2026

Deploy Checklist: New Expensify 2026-11-02 #105665

Closed

75 tasks done

applause-bot Bot mentioned this pull request Nov 2, 2026

Members - Owner badge overlaps with Approver cell when Member column is resized to minimum #105677

Open

2 of 7 tasks

melvin-bot Bot mentioned this pull request Nov 3, 2026

[Due for payment 2026-11-10] [$175] Workspace - Members: show Owner as a badge next to the name, not in the Role column #104754

Open

Conversation

paulnjs commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

Uh oh!

codecov Bot commented Oct 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Oct 24, 2026

Uh oh!

bernhardoj commented Oct 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 26, 2026

Uh oh!

paulnjs commented Oct 26, 2026

Uh oh!

bernhardoj commented Oct 27, 2026

Uh oh!

bernhardoj commented Oct 29, 2026

Uh oh!

paulnjs commented Oct 29, 2026

Uh oh!

paulnjs commented Oct 29, 2026

Uh oh!

bernhardoj commented Oct 29, 2026

Uh oh!

paulnjs commented Oct 29, 2026

Uh oh!

bernhardoj commented Oct 30, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

MelvinBot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 3, 2026

Uh oh!

OSBotify commented Nov 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

paulnjs commented Oct 23, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading

codecov Bot commented Oct 23, 2026 •

edited by github-actions Bot

Loading

bernhardoj commented Oct 24, 2026 •

edited

Loading