Repository navigation
Bump Node to 26.12.1 to block the compromised eMudhra intermediates - #104599
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a326f948ca
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 robertjchen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@robertjchen No QA steps, Ok to checkoff this one? |
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.5.16-0 🚀
|
|
@m-natarajan yep! feel free to check it off |
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.5.18-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Bumps Node to 26.12.1, which rejects TLS chains through the eight compromised eMudhra intermediate CAs (nodejs/node#66871). Node uses its own compiled-in root store, so OS ca-certificates updates don't cover it.
Fixed Issues
For https://github.com/Expensify/Expensify/issues/693812
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14195
Tests
nvm installand confirmnode -vprintsv26.12.1.node -e 'fetch("https://dv-g3b-emudhra.we-have-a-problem.com/").then(r=>console.log(r.status)).catch(e=>console.log(e.cause?.code))'.CERT_REVOKED.Offline tests
N/A
QA Steps
None, this only changes the build and dev Node version.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari