Skip to content

[No QA] Save the Jest cache even when tests fail - #104650

Closed
robertjchen wants to merge 2 commits into
mainfrom
robert-jestCacheSaveAlways
Closed

robertjchen wants to merge 2 commits into
mainfrom
robert-jestCacheSaveAlways

Conversation

@robertjchen

@robertjchen robertjchen commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Jest tests on main have failed since the Node bump in #104599.

What's going on:

  1. Jest keeps a cache of compiled files so tests start fast. The Node version is part of that cache, so the bump made the whole cache stale.
  2. With no usable cache, some large test files take ~10x longer (e.g. GroupChatNameTests went from ~20s to ~200s) and hit their time limits.
  3. CI only saves a new cache when a test job passes. Jobs that fail never save one, so every rerun starts from scratch and fails the same way (https://github.com/Expensify/App/actions/runs/39671276506).

This PR saves the Jest cache even when tests fail, so the next run starts warm instead of failing the same way.

Precedent: lint.yml already saves the ESLint cache the same way (separate restore and save steps, with save on always()).

Fixed Issues

For https://github.com/Expensify/Expensify/issues/693812
PROPOSAL: N/A

Tests

  1. Confirm the test (job N) jobs on this PR show a "Save Jest cache" step.
  2. After merge, confirm the main Process new code merged to main test jobs pass, or pass on the following run once the cache is saved.
  • Verify that no errors appear in the JS console

Offline tests

N/A, CI config only.

QA Steps

None, CI config only.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@robertjchen
robertjchen requested a review from a team as a code owner October 21, 2026 20:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T20:59:15.771820Z da7eb7c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@robertjchen
robertjchen requested review from chuckdries and removed request for a team October 21, 2026 20:55
@melvin-bot
melvin-bot Bot requested a review from deetergp October 21, 2026 20:56
@melvin-bot

melvin-bot Bot commented Oct 21, 2026

Copy link
Copy Markdown

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@robertjchen

Copy link
Copy Markdown
Contributor Author

Not needed: main recovered once the failing shards passed and saved their cache (https://github.com/Expensify/App/actions/runs/39673378157).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant