Repository navigation
[No QA] Save the Jest cache even when tests fail - #104650
Closed
robertjchen wants to merge 2 commits into
Closed
robertjchen wants to merge 2 commits into
robertjchen wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
Not needed: main recovered once the failing shards passed and saved their cache (https://github.com/Expensify/App/actions/runs/39673378157). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Jest tests on main have failed since the Node bump in #104599.
What's going on:
GroupChatNameTestswent from ~20s to ~200s) and hit their time limits.This PR saves the Jest cache even when tests fail, so the next run starts warm instead of failing the same way.
Precedent:
lint.ymlalready saves the ESLint cache the same way (separate restore and save steps, with save onalways()).Fixed Issues
For https://github.com/Expensify/Expensify/issues/693812
PROPOSAL: N/A
Tests
test (job N)jobs on this PR show a "Save Jest cache" step.Process new code merged to maintest jobs pass, or pass on the following run once the cache is saved.Offline tests
N/A, CI config only.
QA Steps
None, CI config only.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari