Skip to content

Give the error row dismiss button a padded hit area #102900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewGable merged 4 commits into from
Oct 26, 2026
Merged

Give the error row dismiss button a padded hit area #102900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2467c1
Give the MessagesRow dismiss button a padded hit area
MelvinBot Oct 2, 2026
a9e7ba4
Merge remote-tracking branch 'origin/main' into claude-messagesRowDis…
MelvinBot Oct 14, 2026
6d5e4ee
Merge remote-tracking branch 'origin/main' into claude-messagesRowDis…
MelvinBot Oct 25, 2026
b0434db
Remove stale mr2 from created-action error row
MelvinBot Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/MessagesRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ function MessagesRow({messages = {}, type, onDismiss, containerStyles, dismissEr
<Tooltip text={dismissText}>
<PressableWithoutFeedback
onPress={onDismiss}
style={styles.touchableButtonImage}

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the stale margin from the created-action error row

When a room-creation error is rendered by ReportActionItemCreated, that caller still passes errorRowStyles={[styles.ml10, styles.mr2, styles.mb2]} at src/pages/inbox/report/ReportActionItemCreated.tsx:70. The new 40px pressable already places the 20px icon 10px from the edge, so the retained 8px right margin moves this dismiss icon 18px inward, unlike the equivalent report-action error rows updated in this commit. Remove styles.mr2 from that caller as well so this error state gets the intended alignment.

Useful? React with 👍 / 👎.

@eVoloshchak eVoloshchak Oct 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot, apply the feedback above

@MelvinBot MelvinBot Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 I removed styles.mr2 from the created-action error row and pushed it (b0434db0). The row now uses [styles.ml10, styles.mb2] in ReportActionItemCreated.tsx:70. This matches the other report-action error rows.

One more caller still passes styles.mr2: the wallet terms error row in WalletPage/index.tsx:895. Its dismiss "X" now sits 18px from the edge. Do you want me to remove it there too?

I couldn't run lint or Prettier in this environment. The change only removes one array item, so CI should confirm it.

role={CONST.ROLE.BUTTON}
accessibilityLabel={dismissText}
sentryLabel={CONST.SENTRY_LABEL.MESSAGES_ROW.DISMISS}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/inbox/report/AncestorReportActionItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ function AncestorReportActionItem({
shouldDisableOpacity={!!reportAction?.pendingAction}
pendingAction={report?.pendingFields?.addWorkspaceRoom ?? report?.pendingFields?.createChat}
errors={report?.errorFields?.addWorkspaceRoom ?? report?.errorFields?.createChat}
errorRowStyles={[styles.ml10, styles.mr2]}
errorRowStyles={styles.ml10}
onClose={deleteAncestorReportAndNavigateToConcierge}
>
{shouldDisplayThreadDivider && (
Expand Down
2 changes: 1 addition & 1 deletion src/pages/inbox/report/ReportActionItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ function ReportActionItem({
}
shouldHideOnDelete={!isDeletedParentAction}
errors={(linkedTransactionRouteError ?? !isOnSearch) ? getLatestErrorMessageField(action as OnyxDataWithErrors) : {}}
errorRowStyles={[styles.ml10, styles.mr2]}
errorRowStyles={styles.ml10}
needsOffscreenAlphaCompositing={isMoneyRequestAction(action)}
shouldDisableStrikeThrough
>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/inbox/report/ReportActionItemCreated.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function ReportActionItemCreated({reportID, policyID}: ReportActionItemCreatedPr
<OfflineWithFeedback
pendingAction={report?.pendingFields?.addWorkspaceRoom ?? report?.pendingFields?.createChat}
errors={report?.errorFields?.addWorkspaceRoom ?? report?.errorFields?.createChat}
errorRowStyles={[styles.ml10, styles.mr2, styles.mb2]}
errorRowStyles={[styles.ml10, styles.mb2]}
onClose={() =>
clearCreateChatError(
report,
Expand Down
2 changes: 1 addition & 1 deletion src/pages/inbox/report/ReportActionItemParentAction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ function ReportActionItemParentAction({
errors={
report?.errorFields?.createChatThread ?? (report?.errorFields?.createChat ? getMicroSecondOnyxErrorWithTranslationKey('report.genericCreateReportFailureMessage') : null)
}
errorRowStyles={[styles.ml10, styles.mr2]}
errorRowStyles={styles.ml10}
onClose={onCloseParentReportActionItem}
>
{ancestors.map(({report: ancestorReport, reportAction: ancestorReportAction, shouldDisplayNewMarker}) => (
Expand Down
Loading