Repository navigation
docs: fix the fact-check findings of #38 - #42
Merged
Merged
Conversation
Make README, docs/, SECURITY.md, CONTRIBUTING.md and site/ say what v0.3.0 does: - security: auto.exec = "auto" decides exec tickets off production; confined agents only (unconfined = true exception, self-reported); PII allow rules leave values in clear; globs match options when they start with - or + or follow a literal --; only * and ? stop at /; the audit masks argv with a fixed set (#40) and skips dry runs; key file mode, password wiping; LOCKSSH_SKIP_COSIGN only without cosign; the first connect ticket is the human's under connect = "ask" only - wrong examples: managed.toml sample now loads; image tag; broken #migrating-from-a-host-install anchor; no Linux packages; truncated output is dropped, not counted - launcher and Docker guide: pii is not routed (#39); doctor runs without a socket; init's home mount; console started by lox run only (allowed_uids, networks in lockfamily.yaml); lox run's socket volume - versions: badge v0.3; lox add pins the latest release; lockssh v0.3.0 takes lox v0.12.0; decisions.md marks #4 to #11 shipped, lockkit v0.20.0, the full code-program table - wording: protocol major, -32009, unmask risk, status, profile add synopsis, argv[0] with a /, secrets are not pseudonyms, max session default, SSH login vs session Closes #38 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes every finding of the docs fact-check #38 (5 FALSE, 4 OVERCLAIM, 6 OUTDATED, 20 MISLEADING) against
origin/mainat 52a4914 (v0.3.0). Docs only: README,docs/, SECURITY.md, CONTRIBUTING.md andsite/.Each item was re-checked in the code first. Notable checks:
managed.tomlsample failsNewManagedwithlockssh.profiles.prod-web is beyond the managed bounds: … family.vault.required = vault (profile prod-web: credentials = none); the new sample loads (checked with a throwaway test, not committed).--runtime-gidsfor lockssh v0.3.0) in lox v0.12.0, so the docs now say v0.12.0 or later for lockssh v0.3.0 (v0.11.0 stays the first with the lockssh lock type).### Migrating from a host installheading, soscripts/install.shis unchanged.python3 scripts/check-site.py site: 6 pages checked, 0 errors;scripts/hygiene.shpasses.Code bugs found by the review, filed separately and documented as they behave today:
lockssh piiis not routed to the consolepii.tomlvalues in clear-*tokens, globs after--); fail-closed proposalThe open point of #38 (a secret cut at
max_output_bytesbefore masking) is not addressed here.Closes #38
🤖 Generated with Claude Code