Repository navigation
feat(console): accept --runtime-gids, lockkit's hub flags (#69) - #70
Merged
Merged
Conversation
lockhttp console registers console.HubOptions as the other locks' consoles do, so lox run can pass it the host's runtime gids (lockhub#212). A socket peer holding one is unconfined (runtime_group), refused with CodeUnconfined unless the profile sets unconfined = true. An invalid list is a usage error; the other hub flags stay refused (the console is policy-only). Tests: unit (argv as lox run writes it, invalid lists, a runtime-group peer refused), integration (the gate served by a console started with --runtime-gids, a runtime-group gate refused), docker e2e (the console listens with --runtime-gids, refuses an invalid one). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er's gid The console adds its machine's runtime gids (confine.RuntimeGIDs): on a CI runner in the docker group the gate is runtime_group whatever --runtime-gids says. Check its absence only where this process holds none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69.
What
lockhttp consolenow registers lockkit's hub flags (console.HubOptions) and passes them toconsole.Run, solox runcan give it--runtime-gidslike the other locks' consoles (lockhub#212).runtime_group) and refused withCodeUnconfinedunless the profile setsunconfined = true(non-production); lockkit's console decides it.--runtime-gidsis a usage error (exit 3) before the terminal or the policy is touched;--hub,--instanceand the other hub flags stay refused (the console is policy-only).Tests
cmd/lockhttp/loxup_test.go): the console starts with the argv lox run writes, with and without--runtime-gids 999,4242, and Run gets the gids; invalid lists are usage errors; a socket peer holding a listed gid is refused withCodeUnconfined/runtime_group.test/integration): lea's gate is served by a console started with--runtime-gids(gids it does not hold); a gate holding one is refused.test/docker/e2e.py): the console listens with--runtime-gids, refuses an invalid one.Docs
docs/usage.md(flag table),docs/lea.md, CHANGELOG (Unreleased: the release that takes the flag, for lockhub'sfamily.RuntimeGIDsSince).🤖 Generated with Claude Code