chore(tests): declare contrib environments in suitespec - #20012
chore(tests): declare contrib environments in suitespec#20012mabdinur wants to merge 19 commits into
Conversation
Codeowners resolved asResolved from the full PR diff against |
Circular import analysis
|
Dependency direction analysis
|
|
BenchmarksBenchmark execution time: 2026-09-03 20:05:17 Comparing candidate commit 24789ee in PR branch Found 0 performance improvements and 7 performance regressions! Performance is the same for 579 metrics, 10 unstable metrics, 2 known flaky benchmarks, 16 flaky benchmarks without significant changes.
|
3386a06 to
d0f8530
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0f85304a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f5e4a21 to
3a1006e
Compare
9fb9ca3 to
1ff7575
Compare
…tespec # Conflicts: # .gitlab/tests.yml
Description
Declare every contrib test environment in
tests/contrib/suitespec.ymland select those environments for uv execution. Riot remains the compatibility baseline during this stage, and the existing.riot/requirements/*.txtlockfiles are reused.Review this first
test_suitespec_matches_riotis the contract for the large YAML change. It expands the suitespec and Riot definitions, then compares each resulting environment by:Dependencies and environment variables are compared as sets, so ordering-only YAML changes do not create noise. Commands remain exact.
This test means reviewers do not need to manually compare 91 suites against
riotfile.py. Review the comparison rules first, then focus on the tworiot_lock_dependenciesoverrides. Those overrides preserve historical Riot lock hashes where uv needs a different install declaration.Ray and Bottle use definitions that work under both runners: Ray workers retain the prepared environment, and Bottle invokes pytest as a module to avoid executable-path shadowing.
Testing
test_suitespec_matches_riotRisks
This switches contrib jobs to uv. The parity test prevents configuration drift; CI covers runner-specific runtime behavior.
Additional Notes