Skip to content

chore(tests): run CI Visibility with uv - #20036

Draft
mabdinur wants to merge 2 commits into
codex/declare-all-suitespecfrom
codex/declare-ci-visibility-suitespec
Draft

chore(tests): run CI Visibility with uv#20036
mabdinur wants to merge 2 commits into
codex/declare-all-suitespecfrom
codex/declare-ci-visibility-suitespec

Conversation

@mabdinur

@mabdinur mabdinur commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

Declare the existing CI Visibility test environments in tests/ci_visibility/suitespec.yml and add the CI Visibility namespace to UV_TEST_SUITES. This switches 11 CI Visibility jobs and 90 concrete environments from Riot to uv without changing their commands, dependencies, Python coverage, environment variables, services, or lock files.

The primary regression gate is test_uv_suitespec_matches_riot. It compares every migrated environment with Riot, including commands, direct dependencies, environment variables, and lock hashes. Reviewers do not need to manually audit each expanded suite variant.

Testing

  • Ran test_uv_suitespec_matches_riot locally
  • Ran test_pass through the Python 3.13 pytest_flaky uv environment
  • Ran scripts/lint suitespec-check
  • Ran targeted formatting and style checks

Risks

This changes the runner for all CI Visibility jobs. The definitions remain equivalent to Riot; CI remains the source of truth for full-suite behavior.

Additional Notes

@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 3, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against codex/declare-all-suitespec using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

tests/ci_visibility/suitespec.yml                                       @DataDog/ci-app-libraries
tests/suitespec.py                                                      @DataDog/python-guild @DataDog/apm-core-python

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 3, 2026

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 3, 2026

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 230 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 230 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=134)
ddtrace.internal.opentelemetry.span -×-> ddtrace.trace  (product:opentelemetry -> product:tracing, score=132)
ddtrace.internal.ci_visibility.filters -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=132)
ddtrace.profiling.scheduler -×-> ddtrace.trace  (product:profiling -> product:tracing, score=132)
ddtrace.internal.ci_visibility.api._base -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=132)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 9 tests - 9 passed on retry View in Datadog

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cece142 | Docs | View more details | Give us feedback!

@mabdinur
mabdinur changed the base branch from codex/declare-debugging-suitespec to codex/declare-all-suitespec September 3, 2026 03:31
@mabdinur
mabdinur force-pushed the codex/declare-ci-visibility-suitespec branch from 3717b18 to 8dcd640 Compare September 3, 2026 03:35
@mabdinur
mabdinur force-pushed the codex/declare-ci-visibility-suitespec branch from 8dcd640 to 0014a03 Compare September 3, 2026 03:40
@pr-commenter

pr-commenter Bot commented Sep 3, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-03 21:19:14

Comparing candidate commit cece142 in PR branch codex/declare-ci-visibility-suitespec with baseline commit 6a7d079 in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 5 performance regressions! Performance is the same for 581 metrics, 10 unstable metrics, 1 known flaky benchmarks, 17 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+2.855µs; +2.981µs] or [+17.018%; +17.769%]

scenario:iastaspects-upper_aspect

  • 🟥 execution_time [+37.594µs; +46.712µs] or [+15.955%; +19.825%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+117.171µs; +122.248µs] or [+29.387%; +30.660%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+622.736ns; +661.668ns] or [+22.991%; +24.428%]

scenario:tracer-small

  • 🟥 execution_time [+36.341µs; +38.371µs] or [+11.107%; +11.727%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-768.406ns; +740.029ns] or [-6.840%; +6.587%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-32.570ns; +34.112ns] or [-5.309%; +5.561%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1727.987ns; +1657.216ns] or [-9.923%; +9.517%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1411.128ns; +1101.268ns] or [-10.620%; +8.288%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-327.252ns; +336.613ns] or [-8.787%; +9.038%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-260.561ns; +263.391ns] or [-8.734%; +8.829%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-77.815ns; +72.669ns] or [-6.816%; +6.366%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-4217.897ns; +3748.950ns] or [-10.303%; +9.158%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-809.549ns; +788.173ns] or [-9.921%; +9.659%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-59.218µs; +51.189µs] or [-10.228%; +8.841%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:span-start

  • 🟥 execution_time [+1.812ms; +1.962ms] or [+12.673%; +13.720%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-casefold_noaspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:iastaspects-upper_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:telemetryaddmetric-record-100-metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants