Skip to content

Make dd-trace-java.test-jvm-constraints reports additional JVM data in test task inputs - #12630

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/test-jvm-cache-inputs
Sep 24, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/test-jvm-cache-inputs

Conversation

@bric3

@bric3 bric3 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Include the selected test JVM's vendor, full runtime version and VM version in task inputs through testJvmConstraints. The inputs follow each task's final javaLauncher, including defaults and overrides.

Motivation

Changing a JVM patch/build or vendor can currently reuse test results from the same Java major version. This makes those changes invalidate both up-to-date checks and build-cache entries.

Related to the S3 build cache in #12604.

Additional Notes

Regression tests vary each metadata field while keeping the executable and Java major version fixed, and check both up-to-date and build-cache reuse. Identity uses reported JVM metadata rather than hashes of JDK binaries.

Contributor Checklist

@bric3 bric3 added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM labels Sep 24, 2026
@datadog-datadog-prod-us1

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.98 s 13.97 s [-0.8%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent 12.95 s 12.97 s [-0.9%; +0.6%] (no difference)
startup:petclinic:appsec:Agent 16.98 s 16.89 s [-0.5%; +1.5%] (no difference)
startup:petclinic:iast:Agent 16.88 s 16.36 s [-1.3%; +7.7%] (no difference)
startup:petclinic:profiling:Agent 16.66 s 16.72 s [-1.5%; +0.7%] (no difference)
startup:petclinic:sca:Agent 16.92 s 16.92 s [-0.9%; +0.9%] (no difference)
startup:petclinic:tracing:Agent 16.16 s 16.17 s [-1.0%; +0.9%] (no difference)

Commit: 95abc7b9 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3 bric3 changed the title Fingerprint the selected JVM in test task inputs Make dd-trace-java.test-jvm-constraints reports additional JVM data in test task inputs Sep 24, 2026
@bric3
bric3 marked this pull request as ready for review September 24, 2026 15:30
@bric3
bric3 requested review from a team as code owners September 24, 2026 15:30
@bric3
bric3 requested review from sarahchen6 and removed request for a team September 24, 2026 15:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T15:34:46.707734Z 95abc7b Draft marked ready
🔒 Security Review ✅ Completed 2026-09-24T15:32:55.335139Z 95abc7b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sarahchen6 sarahchen6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@bric3

bric3 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-24 15:43:23 UTC ℹ️ Start processing command /merge


2026-09-24 15:43:27 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-24 16:46:20 UTC ℹ️ MergeQueue: This merge request was merged

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Each test task uses its final Java launcher data. A vendor or full JVM version change now invalidates the task cache.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 95abc7b · @DataDog review to ask questions

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 5129467 into master Sep 24, 2026
618 of 624 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/test-jvm-cache-inputs branch September 24, 2026 16:46
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants