Make dd-trace-java.test-jvm-constraints reports additional JVM data in test task inputs - #12630
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
dd-trace-java.test-jvm-constraints reports additional JVM data in test task inputs
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
5129467
into
master
What Does This Do
Include the selected test JVM's vendor, full runtime version and VM version in task inputs through
testJvmConstraints. The inputs follow each task's finaljavaLauncher, including defaults and overrides.Motivation
Changing a JVM patch/build or vendor can currently reuse test results from the same Java major version. This makes those changes invalidate both up-to-date checks and build-cache entries.
Related to the S3 build cache in #12604.
Additional Notes
Regression tests vary each metadata field while keeping the executable and Java major version fixed, and check both up-to-date and build-cache reuse. Identity uses reported JVM metadata rather than hashes of JDK binaries.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue