Skip to content

Make dd-trace-java.test-jvm-constraints report architecture in test task inputs - #12635

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/test-jvm-architecture
Sep 24, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/test-jvm-architecture

Conversation

@bric3

@bric3 bric3 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Track the JVM operating system and architecture as inputs of each Test task configured by dd-trace-java.test-jvm-constraints.

Motivation

Changing operating systems or architectures could currently reuse test results from the same Java version and vendor. This makes platform changes invalidate both up-to-date checks and build-cache entries.

Follow-up to #12630 and aligned with #12631. Context #12604

Additional Notes

The platform uses the JVM-reported os.name and os.arch values.

Contributor Checklist

@bric3 bric3 added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM labels Sep 24, 2026
@bric3 bric3 changed the title Track test JVM architecture in task inputs Make dd-trace-java.test-jvm-constraints reports JVM arch in test task inputs Sep 24, 2026
@bric3
bric3 marked this pull request as ready for review September 24, 2026 20:10
@bric3
bric3 requested review from a team as code owners September 24, 2026 20:10
@bric3
bric3 requested review from dougqh and removed request for a team September 24, 2026 20:10
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T20:13:31.003485Z ecfbe90 Draft marked ready
🔒 Security Review ✅ Completed 2026-09-24T20:13:32.903006Z ecfbe90 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ecfbe904b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@bric3
bric3 force-pushed the bdu/test-jvm-architecture branch from ecfbe90 to a3c034b Compare September 24, 2026 20:18
@bric3 bric3 changed the title Make dd-trace-java.test-jvm-constraints reports JVM arch in test task inputs Track test JVM platform in task inputs Sep 24, 2026
@bric3 bric3 changed the title Track test JVM platform in task inputs Make dd-trace-java.test-jvm-constraints reports archtecture in test task inputs Sep 24, 2026

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

The new input records the Gradle daemon architecture. A test launcher with another architecture can still reuse stale cached results.

Open Bits AI session

🤖 Bits Code Review · Commit ecfbe90 · @DataDog review to ask questions

@datadog-prod-us1-5

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.93 s 13.93 s [-1.0%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent 12.95 s 13.01 s [-1.1%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 17.07 s 16.92 s [+0.1%; +1.7%] (maybe worse)
startup:petclinic:iast:Agent 17.00 s 17.00 s [-0.8%; +0.8%] (no difference)
startup:petclinic:profiling:Agent 16.66 s 16.87 s [-2.3%; -0.1%] (maybe better)
startup:petclinic:sca:Agent 16.87 s 16.68 s [+0.2%; +2.1%] (maybe worse)
startup:petclinic:tracing:Agent 16.09 s 16.07 s [-0.8%; +1.1%] (no difference)

Commit: a3c034b8 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3 bric3 mentioned this pull request Sep 24, 2026
7 tasks
@bric3
bric3 requested a review from sarahchen6 September 24, 2026 21:10
@sarahchen6 sarahchen6 changed the title Make dd-trace-java.test-jvm-constraints reports archtecture in test task inputs Make dd-trace-java.test-jvm-constraints report architecture in test task inputs Sep 24, 2026
@bric3

bric3 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-24 21:43:01 UTC ℹ️ Start processing command /merge


2026-09-24 21:43:05 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-24 22:47:57 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 4877369 into master Sep 24, 2026
614 of 617 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/test-jvm-architecture branch September 24, 2026 22:47
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants