Skip to content

🪞 12539 - Improve Muzzle version range failure diagnostics - #12592

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
community-pr-12539
Sep 21, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
community-pr-12539

Conversation

@bric3

@bric3 bric3 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • retain exceptions embedded in Aether VersionRangeResult objects across retries
  • include each exception and its cause chain in the final Muzzle version-range failure message
  • add regression coverage for empty results returned with embedded exceptions

Why

Aether may return a VersionRangeResult with no bounds while recording metadata download, checksum, local-file, or parsing failures in VersionRangeResult.exceptions. Muzzle currently reports only the empty bounds and version count, which hides the client-side cause of intermittent resolution failures.

Testing

  • ./gradlew -p buildSrc :test -PrunBuildSrcTests --tests datadog.gradle.plugin.muzzle.MuzzleMavenRepoUtilsTest -x :call-site-instrumentation-plugin:test -x :modifiable-config-agent:test
  • ./gradlew -p buildSrc spotlessCheck

This PR mirrors #12539 from @aalbertjay to be able to run in CI.

@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling type: bug tag: ai generated Largely based on code generated by an AI or LLM labels Sep 21, 2026 — with ChatGPT Codex Connector
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 59.13% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4f5f973 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.78 s 14.65 s [-0.0%; +1.8%] (no difference)
startup:insecure-bank:tracing:Agent 13.61 s 13.68 s [-1.4%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 17.01 s 16.94 s [-0.6%; +1.4%] (no difference)
startup:petclinic:iast:Agent 17.01 s 16.90 s [-0.2%; +1.4%] (no difference)
startup:petclinic:profiling:Agent 16.65 s 16.65 s [-1.1%; +1.1%] (no difference)
startup:petclinic:sca:Agent 16.93 s 16.81 s [-0.5%; +1.9%] (no difference)
startup:petclinic:tracing:Agent 16.12 s 16.08 s [-0.7%; +1.2%] (no difference)

Commit: 4f5f9733 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3
bric3 marked this pull request as ready for review September 21, 2026 18:51
@bric3
bric3 requested a review from a team as a code owner September 21, 2026 18:51
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T18:56:01.378581Z 5253a9f Draft marked ready
🔒 Security Review Completed 2026-09-21T18:58:06.366545Z 5253a9f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left minor note.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The retry flow keeps embedded Aether exceptions from each attempt. It reports their cause chains when resolution fails. No concrete regression remains in the changed code.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 5253a9f · @DataDog review to ask questions

@bric3

bric3 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 21, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-21 20:04:23 UTC ℹ️ Start processing command /merge


2026-09-21 20:04:28 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-21 21:18:35 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 2425f43 into master Sep 21, 2026
605 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the community-pr-12539 branch September 21, 2026 21:18
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants