Use Fabric as the primary Muzzle Depot repository - #12621
Draft
aalbertjay wants to merge 1 commit into
Draft
aalbertjay wants to merge 1 commit into
aalbertjay wants to merge 1 commit into
Conversation
Contributor
Author
bric3
reviewed
Sep 24, 2026
bric3
left a comment
bric3
left a comment
Contributor
There was a problem hiding this comment.
I'll mirror the PR, but left a few notes about what I will need to change.
🙏 Thanks to the proposed fix !
Comment on lines
+25
to
+28
| private const val DEPOT_JAVA_HOST = "depot-read-api-java.us1.ddbuild.io" | ||
| private const val DEPOT_JAVA_FABRIC_URL = | ||
| "https://depot-read-api-java.rapid-dependency-management-depot.all-clusters.local-dc.fabric.dog:8443/" + | ||
| "magicmirror/magicmirror/@current/" |
Contributor
There was a problem hiding this comment.
issue: I'd rather not have depot URL here, in constants, they should be configurable, I'll look into that in the mirror PR.
Comment on lines
+25
to
+29
| private const val DEPOT_JAVA_URL = | ||
| "https://depot-read-api-java.us1.ddbuild.io/magicmirror/magicmirror/@current/" | ||
| private const val DEPOT_JAVA_FABRIC_URL = | ||
| "https://depot-read-api-java.rapid-dependency-management-depot.all-clusters.local-dc.fabric.dog:8443/" + | ||
| "magicmirror/magicmirror/@current/" |
Contributor
There was a problem hiding this comment.
issue: I'd rather not have depot URL here, in constants, they should be configurable, I'll look into that in the mirror PR.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
us1.ddbuild.ioendpointWhy
A transient TCP connection timeout to the
us1.ddbuild.ioendpoint can prevent Muzzle version-range resolution. The Go dependency configuration already uses the corresponding Fabric endpoint first and retains the external endpoint as fallback. Registering both repositories gives Aether an alternate network path within the same resolution attempt.Testing
./gradlew -p buildSrc :test -PrunBuildSrcTests --tests datadog.gradle.plugin.muzzle.MuzzleMavenRepoUtilsTest -x :call-site-instrumentation-plugin:test -x :modifiable-config-agent:test./gradlew -p buildSrc spotlessCheck