Skip to content

Fix NullPointerException in Exception Replay #12429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 3 commits into from
Sep 10, 2026
+7 −3
Merged

Fix NullPointerException in Exception Replay #12429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9039081
Fix NullPointerException in Exception Replay
jpbempel Sep 8, 2026
b1f984d
call only once getStackTrace
jpbempel Sep 8, 2026
027c1bf
fix possible NPE from chained exceptions
jpbempel Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...gent-debugger/src/main/java/com/datadog/debugger/exception/AbstractExceptionDebugger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,12 @@ public void handleException(Throwable t, AgentSpan span) {
Throwable throwable;
int chainedExceptionIdx = 0;
while ((throwable = chainedExceptions.pollFirst()) != null) {
StackTraceElement[] stackTrace = throwable.getStackTrace();
if (stackTrace == null || stackTrace.length == 0) {
continue;
}
ExceptionProbeManager.CreationResult creationResult =
exceptionProbeManager.createProbesForException(
throwable.getStackTrace(), chainedExceptionIdx);
exceptionProbeManager.createProbesForException(stackTrace, chainedExceptionIdx);
if (creationResult.probesCreated > 0) {
if (!applyConfigAsync) {
applyExceptionConfiguration(fingerprint);
Expand Down
3 changes: 2 additions & 1 deletion ...agent-debugger/src/main/java/com/datadog/debugger/exception/DefaultExceptionDebugger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ protected boolean shouldHandleException(Throwable t, AgentSpan span) {
}
// do not handle exception with no stacktrace. cannot capture anything for it.
// includes also FastThrow ones
if (t.getStackTrace().length == 0) {
StackTraceElement[] stackTrace = t.getStackTrace();
if (stackTrace == null || stackTrace.length == 0) {
return false;
}
return circuitBreaker.trip();
Expand Down