Fix NullPointerException in Exception Replay - #12429
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
The new null check calls getStackTrace() twice for each exception with a non-empty stack. The second call copies the stack array again before the circuit breaker can reject the exception.
🤖 Datadog Autotest · Commit 4d4975a · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d4975ac09
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (361.927 µs) : 333, 391
. : milestone, 362,
basic (341.859 µs) : 335, 349
. : milestone, 342,
loop (8.116 ms) : 8051, 8180
. : milestone, 8116,
section candidate
noprobe (357.716 µs) : 330, 385
. : milestone, 358,
basic (338.694 µs) : 332, 346
. : milestone, 339,
loop (8.116 ms) : 8052, 8181
. : milestone, 8116,
|
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
The null check prevents Exception Replay from reading the length of a null stack trace. The existing empty-stack behavior and circuit-breaker path stay unchanged.
🤖 Datadog Autotest · Commit 0ca7ebe · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
For FastThrow, getStackTrace can return null instead of empty StackTraceElement array
0ca7ebe to
027c1bf
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
For FastThrow, getStackTrace can return null instead of empty StackTraceElement array
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-6173