Conversation
There was a problem hiding this comment.
Pull request overview
Updates the v2 → v3 migration guide to document the firstPartyHosts configuration format change, helping users migrate distributed tracing host configuration correctly.
Changes:
- Expands the
firstPartyHostsentry in the “Property renames and relocations” table to mention a format change. - Adds a dedicated “
firstPartyHostsformat change” section with v2 vs v3 TypeScript examples.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cdn34dd
force-pushed
the
carlosnogueira/issue-1207/add-first-party-hosts-migration-guide
branch
from
ec674b2 to
07e4226
Compare
cdn34dd
force-pushed
the
carlosnogueira/issue-1207/add-first-party-hosts-migration-guide
branch
from
07e4226 to
69b8444
Compare
cdn34dd
deleted the
carlosnogueira/issue-1207/add-first-party-hosts-migration-guide
branch
There was a problem hiding this comment.
Pull request overview
Updates the migration guide to document the breaking change to firstPartyHosts when moving from SDK v2 to v3, helping users correctly configure distributed tracing propagation for first-party resources.
Changes:
- Expanded the
firstPartyHostsrow in the “Property renames and relocations” table to mention the format change. - Added a dedicated “
firstPartyHostsformat change” migration section with v2 vs v3 configuration examples.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | `nativeViewTracking` | `RumConfiguration` | Moved. | | ||
| | `nativeInteractionTracking` | `RumConfiguration` | Moved. | | ||
| | `firstPartyHosts` | `RumConfiguration` | Moved. | | ||
| | `firstPartyHosts` | `RumConfiguration` | Moved. Format changed from `(string \| FirstPartyHost)[]` to `FirstPartyHost[]`. | |
There was a problem hiding this comment.
The type change in this table row looks inaccurate for v3: the public RumConfigurationOptions.firstPartyHosts is FirstPartyHost[] (no string/union support). To avoid confusion, consider describing the change as string[] (v2) -> FirstPartyHost[] (v3), or otherwise clarify where (string | FirstPartyHost)[] is valid.
| | `firstPartyHosts` | `RumConfiguration` | Moved. Format changed from `(string \| FirstPartyHost)[]` to `FirstPartyHost[]`. | | |
| | `firstPartyHosts` | `RumConfiguration` | Moved. Format changed from `string[]` (v2) to `FirstPartyHost[]` (v3). | |
| import { PropagatorType } from '@datadog/mobile-react-native'; | ||
|
|
||
| const config = new CoreConfiguration( | ||
| CLIENT_TOKEN, | ||
| ENVIRONMENT, | ||
| TrackingConsent.GRANTED, |
There was a problem hiding this comment.
This snippet includes an import { PropagatorType } ... line but omits other required imports (CoreConfiguration, TrackingConsent, etc.), which makes it hard to copy/paste as-is. Either include the missing imports, or remove the import line and keep the snippet as pseudocode for consistency with the other examples in this guide.
What does this PR do?
Add migration section for
firstPartyHostsconfiguration property.Motivation
Issue:1207
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)