[APPS] Add OAuth auth for Apps uploads#422
Closed
sdkennedy2 wants to merge 2 commits into
Closed
Conversation
2cc5df7 to
bdeb952
Compare
64f45bc to
badaa3a
Compare
bdeb952 to
fb3a06d
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #393.
Adds Apps upload OAuth wiring on top of the shared core OAuth/request helpers:
apps.authOverrides.methodandDD_APPS_AUTH_METHOD/DATADOG_APPS_AUTH_METHODgetAuthenticatedRequestand the internalDoAuthenticatedRequesttypedoAuthenticatedRequestValidation
yarn workspace @dd/tests test:unit packages/plugins/apps/src/auth.test.ts packages/plugins/apps/src/upload.test.ts packages/plugins/apps/src/index.test.ts packages/plugins/apps/src/validate.test.tsyarn cli integritygit diff --check