Skip to content

[APPS] Add OAuth auth for Apps uploads#422

Closed
sdkennedy2 wants to merge 2 commits into
oriol.torrillas/apps-oauth-pkce-uploadfrom
codex/apps-upload-oauth-wiring
Closed

[APPS] Add OAuth auth for Apps uploads#422
sdkennedy2 wants to merge 2 commits into
oriol.torrillas/apps-oauth-pkce-uploadfrom
codex/apps-upload-oauth-wiring

Conversation

@sdkennedy2

Copy link
Copy Markdown
Collaborator

Summary

Depends on #393.

Adds Apps upload OAuth wiring on top of the shared core OAuth/request helpers:

  • adds Apps-scoped auth selection via apps.authOverrides.method and DD_APPS_AUTH_METHOD / DATADOG_APPS_AUTH_METHOD
  • defaults Apps uploads to API-key auth
  • adds getAuthenticatedRequest and the internal DoAuthenticatedRequest type
  • makes upload context require doAuthenticatedRequest
  • uses a throw-if-called dry-run request sentinel so dry-run does not require auth but still catches accidental network execution
  • updates Apps README/config/tests for upload OAuth behavior

Validation

  • yarn workspace @dd/tests test:unit packages/plugins/apps/src/auth.test.ts packages/plugins/apps/src/upload.test.ts packages/plugins/apps/src/index.test.ts packages/plugins/apps/src/validate.test.ts
  • yarn cli integrity
  • git diff --check

@sdkennedy2 sdkennedy2 force-pushed the oriol.torrillas/apps-oauth-pkce-upload branch from 2cc5df7 to bdeb952 Compare June 16, 2026 18:54
@sdkennedy2 sdkennedy2 force-pushed the codex/apps-upload-oauth-wiring branch from 64f45bc to badaa3a Compare June 16, 2026 18:54
@sdkennedy2 sdkennedy2 force-pushed the oriol.torrillas/apps-oauth-pkce-upload branch from bdeb952 to fb3a06d Compare June 16, 2026 21:05
@sdkennedy2

Copy link
Copy Markdown
Collaborator Author

Closing this because the Apps upload OAuth wiring has been folded back into #393 after collapsing the stack. #421 remains the separate optional-dependency integrity PR.

@sdkennedy2 sdkennedy2 closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant