Skip to content

[APPS] Add OAuth auth for Apps dev server#413

Closed
sdkennedy2 wants to merge 1 commit into
codex/apps-upload-oauth-wiringfrom
sdkennedy2/apps-oauth-dev-server
Closed

[APPS] Add OAuth auth for Apps dev server#413
sdkennedy2 wants to merge 1 commit into
codex/apps-upload-oauth-wiringfrom
sdkennedy2/apps-oauth-dev-server

Conversation

@sdkennedy2

@sdkennedy2 sdkennedy2 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Depends on #422.

Adds OAuth-aware authenticated request wiring for the Apps Vite dev server only:

  • passes the resolved Apps auth method into the dev-server middleware
  • reuses the Apps getAuthenticatedRequest helper and DoAuthenticatedRequest type
  • returns a clear 403 for executeAction when API-key auth lacks credentials
  • keeps debug bundle handling available without Datadog auth

Validation

  • yarn workspace @dd/tests test:unit packages/plugins/apps/src/vite/dev-server.test.ts packages/plugins/apps/src/vite/index.test.ts packages/plugins/apps/src/index.test.ts
  • yarn cli integrity
  • git diff --check

@sdkennedy2

Copy link
Copy Markdown
Collaborator Author

@codex review
@cursor review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 7391f768ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/plugins/apps/src/vite/dev-server.ts Outdated
Comment thread packages/plugins/apps/src/vite/dev-server.ts Outdated
Comment thread packages/plugins/apps/src/vite/dev-server.ts Outdated
@sdkennedy2 sdkennedy2 force-pushed the sdkennedy2/apps-oauth-dev-server branch from e50f8b9 to 4272ece Compare June 12, 2026 20:21
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 12, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 74e69b8 | Docs | Datadog PR Page | Give us feedback!

@sdkennedy2 sdkennedy2 force-pushed the sdkennedy2/apps-oauth-dev-server branch 3 times, most recently from 8da66bb to cb9988c Compare June 12, 2026 20:40
@sdkennedy2 sdkennedy2 marked this pull request as ready for review June 12, 2026 20:43
@sdkennedy2 sdkennedy2 requested review from a team and yoannmoinet as code owners June 12, 2026 20:43
@sdkennedy2 sdkennedy2 force-pushed the sdkennedy2/apps-oauth-dev-server branch from cb9988c to 335a2e6 Compare June 16, 2026 16:28
@sdkennedy2 sdkennedy2 force-pushed the oriol.torrillas/apps-oauth-pkce-upload branch from 39882a8 to b2ac87c Compare June 16, 2026 17:01
@sdkennedy2 sdkennedy2 force-pushed the sdkennedy2/apps-oauth-dev-server branch from 335a2e6 to 3eb7b73 Compare June 16, 2026 17:03
@sdkennedy2 sdkennedy2 force-pushed the oriol.torrillas/apps-oauth-pkce-upload branch from b2ac87c to 2cc5df7 Compare June 16, 2026 18:22
@sdkennedy2 sdkennedy2 force-pushed the sdkennedy2/apps-oauth-dev-server branch from 3eb7b73 to d458ac3 Compare June 16, 2026 18:27
@sdkennedy2 sdkennedy2 changed the base branch from oriol.torrillas/apps-oauth-pkce-upload to codex/apps-upload-oauth-wiring June 16, 2026 18:27
@sdkennedy2 sdkennedy2 force-pushed the codex/apps-upload-oauth-wiring branch from 64f45bc to badaa3a Compare June 16, 2026 18:54
@sdkennedy2 sdkennedy2 force-pushed the sdkennedy2/apps-oauth-dev-server branch from d458ac3 to 74e69b8 Compare June 16, 2026 18:55
@sdkennedy2

Copy link
Copy Markdown
Collaborator Author

Closing this because the Apps dev-server OAuth wiring has been folded back into #393 after collapsing the stack. #421 remains the separate optional-dependency integrity PR.

@sdkennedy2 sdkennedy2 closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant