Repository navigation
docs: record the strict required check that main already enforces - #761
Merged
Merged
Conversation
The live ruleset 23966555 has required pull requests to be up to date with main since 2026-10-07, but .github/rulesets/main.json, the agent guide, the ai-ops runbook and test_multi_agent_doc still described the non-strict check. Re-applying the file with the documented PUT would have turned strict off again. Set strict_required_status_checks_policy to true and add require_extra_approval_for_unattributed_changes so the file equals the live ruleset, rewrite the multi-agent guidance for pull requests blocked as behind main, and pin the strict setting in the test. Closes #760 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: architect <architect@hive.kubestellar.io>
3 tasks
This was referenced Oct 18, 2026
danathar-atomic-hive Bot
added a commit
that referenced
this pull request
Oct 18, 2026
…#763) #761 made the protect main ruleset strict and added require_extra_approval_for_unattributed_changes, and rewrote the branch-protection, multi-agent and ai-ops runbook prose to match. Only the strict value and one backticked phrase on the multi-agent page were read by a test: the new key could be dropped or set false, and every other sentence about strict could be reverted or contradicted, with the suite green. Pin the key, join the branch-protection bullet and the runbook's main is red section to the strict value, and read the multi-agent sentences that say what strict costs. Signed-off-by: quality <320561496+danathar-atomic-hive[bot]@users.noreply.github.com> Co-authored-by: quality <320561496+danathar-atomic-hive[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub already requires a pull request to
mainto be up to date withmain, and to pass its tests that way, before it can merge. That setting was turned on on 2026-10-07. The repository's copy of the branch rules, the agent guide and the runbook still said it was off. This pull request brings them in line with what GitHub actually enforces.Agents read these documents. Before this change, the guide warned them about a failure GitHub now prevents, and didn't tell them what really happens now: after each merge, the other open pull requests are blocked as "behind
main" until they are updated. The stored copy was also risky, because re-applying it with the documented command would have turned the setting off again. Nothing changes on GitHub, which already has this setting.This is option A on #760, which the owner approved.
Refactor
Claims:
.github/rulesets/main.json,docs/multi-agent.md("Staying out of each other's way"),docs/ai-ops-runbook.md("mainis red", first paragraph),docs/branch-protection.md(required_status_checksbullet), andtests/test_multi_agent_doc.py(Ruleset.test_test_is_required_against_the_latest_main)..github/rulesets/main.json:strict_required_status_checks_policyis nowtrue, andrequire_extra_approval_for_unattributed_changes: trueis added. Compared field by field withgh api repos/Danathar/atomic-image-builder/rulesets/23966555, the only difference left isrequired_reviewers: [], which GitHub adds on its side and which is empty. Applying the file with thePUTindocs/branch-protection.mdnow changes nothing.docs/multi-agent.md: the paragraph "Expect two green pull requests to be red together" becomes "Expect a pull request to fall behindmain". It says the check is strict and what that costs (each merge makes the other open pull requests stale). It keeps the feat: read back the record every merged agent pull request leaves #632/docs: add .claude/risk-config.json, the risk tiers in a form a program reads #636 incident as the reason strict is on.docs/ai-ops-runbook.md: the "mainis red" section no longer says two pull requests that each pass alone can fail together onmain. The feat: read back the record every merged agent pull request leaves #632/docs: add .claude/risk-config.json, the risk tiers in a form a program reads #636 history stays, dated before strict.docs/branch-protection.md: therequired_status_checksbullet now says the check is strict. The rule list the doc test compares (BOLD_LEAD) is unchanged.tests/test_multi_agent_doc.py: the test now pinsTrueand the new sentence. Its comment says turning strict off means the page has to warn about pair failures again..claude/checkpoint.md's 2026-10-03 entry still mentions the "unstricttestcheck". It is a dated record of that day, so it is left as written.No overlap with #759's hunks: #759 edits
docs/ai-ops-runbook.mdat lines 26–36 and 111+, and this pull request edits lines 39–46.Tier 4 under
docs/risk-tiers.md(.github/rulesets/**).How it was checked
python3 -m unittest discover -s tests: 2540 tests, OK (50 skipped).ruff check .(0.17.0): clean.git diff --check: clean.strict_required_status_checks_policyback tofalsein the file failstest_test_is_required_against_the_latest_main.gh api repos/Danathar/atomic-image-builder/rules/branches/mainreports ruleset 23966555 with stricttrue.Closes #760
Filed by architect agent (ACMM L6 — full mode)
🤖 Generated with Claude Code
— hive: agent=architect backend=claude model=claude-opus-5-5 effort=high claude=2.1.301