Skip to content

docs: record the strict required check that main already enforces - #761

Merged
danathar-atomic-hive[bot] merged 1 commit into
mainfrom
arch/ruleset-strict
Oct 18, 2026
Merged

danathar-atomic-hive[bot] merged 1 commit into
mainfrom
arch/ruleset-strict

Conversation

@danathar-atomic-hive

Copy link
Copy Markdown
Contributor

Summary

GitHub already requires a pull request to main to be up to date with main, and to pass its tests that way, before it can merge. That setting was turned on on 2026-10-07. The repository's copy of the branch rules, the agent guide and the runbook still said it was off. This pull request brings them in line with what GitHub actually enforces.

Agents read these documents. Before this change, the guide warned them about a failure GitHub now prevents, and didn't tell them what really happens now: after each merge, the other open pull requests are blocked as "behind main" until they are updated. The stored copy was also risky, because re-applying it with the documented command would have turned the setting off again. Nothing changes on GitHub, which already has this setting.

This is option A on #760, which the owner approved.

Refactor

Claims: .github/rulesets/main.json, docs/multi-agent.md ("Staying out of each other's way"), docs/ai-ops-runbook.md ("main is red", first paragraph), docs/branch-protection.md (required_status_checks bullet), and tests/test_multi_agent_doc.py (Ruleset.test_test_is_required_against_the_latest_main).

.claude/checkpoint.md's 2026-10-03 entry still mentions the "unstrict test check". It is a dated record of that day, so it is left as written.

No overlap with #759's hunks: #759 edits docs/ai-ops-runbook.md at lines 26–36 and 111+, and this pull request edits lines 39–46.

Tier 4 under docs/risk-tiers.md (.github/rulesets/**).

How it was checked

  • python3 -m unittest discover -s tests: 2540 tests, OK (50 skipped).
  • ruff check . (0.17.0): clean. git diff --check: clean.
  • Mutation: setting strict_required_status_checks_policy back to false in the file fails test_test_is_required_against_the_latest_main.
  • Live check: gh api repos/Danathar/atomic-image-builder/rules/branches/main reports ruleset 23966555 with strict true.

Closes #760


Filed by architect agent (ACMM L6 — full mode)

🤖 Generated with Claude Code

— hive: agent=architect backend=claude model=claude-opus-5-5 effort=high claude=2.1.301

The live ruleset 23966555 has required pull requests to be up to date
with main since 2026-10-07, but .github/rulesets/main.json, the agent
guide, the ai-ops runbook and test_multi_agent_doc still described the
non-strict check. Re-applying the file with the documented PUT would
have turned strict off again.

Set strict_required_status_checks_policy to true and add
require_extra_approval_for_unattributed_changes so the file equals the
live ruleset, rewrite the multi-agent guidance for pull requests blocked
as behind main, and pin the strict setting in the test.

Closes #760

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: architect <architect@hive.kubestellar.io>
@danathar-atomic-hive danathar-atomic-hive Bot added author/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 18, 2026
@danathar-atomic-hive
danathar-atomic-hive Bot merged commit 5e1b00f into main Oct 18, 2026
6 checks passed
@danathar-atomic-hive danathar-atomic-hive Bot removed author/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 18, 2026
danathar-atomic-hive Bot added a commit that referenced this pull request Oct 18, 2026
…#763)

#761 made the protect main ruleset strict and added
require_extra_approval_for_unattributed_changes, and rewrote the
branch-protection, multi-agent and ai-ops runbook prose to match. Only the
strict value and one backticked phrase on the multi-agent page were read
by a test: the new key could be dropped or set false, and every other
sentence about strict could be reverted or contradicted, with the suite
green.

Pin the key, join the branch-protection bullet and the runbook's main is
red section to the strict value, and read the multi-agent sentences that
say what strict costs.

Signed-off-by: quality <320561496+danathar-atomic-hive[bot]@users.noreply.github.com>
Co-authored-by: quality <320561496+danathar-atomic-hive[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[architect] Branch rule on main requires up-to-date pull requests, but the committed rule set, agent guide and test still say it does not

0 participants