Repository navigation
test: read the strict ruleset prose and the unattributed-approval key - #763
Merged
danathar-atomic-hive[bot] merged 1 commit intoOct 18, 2026
Merged
Conversation
#761 made the protect main ruleset strict and added require_extra_approval_for_unattributed_changes, and rewrote the branch-protection, multi-agent and ai-ops runbook prose to match. Only the strict value and one backticked phrase on the multi-agent page were read by a test: the new key could be dropped or set false, and every other sentence about strict could be reverted or contradicted, with the suite green. Pin the key, join the branch-protection bullet and the runbook's main is red section to the strict value, and read the multi-agent sentences that say what strict costs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: quality <320561496+danathar-atomic-hive[bot]@users.noreply.github.com>
danathar-atomic-hive
Bot
added
author/hive
Contributor
Author
danathar-atomic-hive
Bot
removed
role/trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary. GitHub protects
mainwith a rule that this repository keeps a copy of, and three pages explain it. #761 made that rule require pull requests to be up to date withmainbefore they merge, and turned on an extra-approval setting. The tests checked almost none of it: 1 of 12 deliberate breakages was caught. This PR adds four tests. With them, dropping the new setting, or editing a page so it contradicts the rule, fails CI. Only tests change.Test Improvement
Four tests, each reading committed files only:
tests/test_branch_ruleset.pyRulesetTests.test_unattributed_changes_need_an_extra_approval:require_extra_approval_for_unattributed_changesistruein thepull_requestrule. The documentedPUTreplaces the live rules with the file's, so dropping the key here turns it off onmainthe next time someone re-applies the file.DocTests.test_the_doc_says_whether_the_required_check_is_strict: therequired_status_checksbullet indocs/branch-protection.mdstates the file's strict value, and says "has to be up to date withmain" only when strict is on.tests/test_ai_ops_runbook.pytest_main_is_red_says_whether_the_check_is_strict:## main is redkeeps its up-to-date and "can no longer merge untested together" clauses only while strict is on.tests/test_multi_agent_doc.pyRuleset.test_the_page_says_what_strict_costs: the four sentences that tell an agent a pull request will fall behindmain, and that the remedy is an update, not a fix.Mutation audit (12 hand mutants on
.github/rulesets/main.jsonand the three pages, plus a no-op control, full suite each run):Suite goes from 2540 to 2544 tests, all passing.
ruff checkis clean.Closes #762
Filed by quality agent (ACMM L4/L6 — full mode)
🤖 Generated with Claude Code
— hive: agent=quality backend=claude model=claude-opus-5-5 effort=high claude=2.1.302