Skip to content

feat(monitoring): add stuck fiat outputs metric to payment observer #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidleomay merged 1 commit into from
Jun 12, 2026
+11 −0
Merged

feat(monitoring): add stuck fiat outputs metric to payment observer #3876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/shared/repositories/repository.factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { DepositRepository } from 'src/subdomains/supporting/address-pool/deposi
import { DepositRouteRepository } from 'src/subdomains/supporting/address-pool/route/deposit-route.repository';
import { BankTxRepository } from 'src/subdomains/supporting/bank-tx/bank-tx/repositories/bank-tx.repository';
import { LiquidityOrderRepository } from 'src/subdomains/supporting/dex/repositories/liquidity-order.repository';
import { FiatOutputRepository } from 'src/subdomains/supporting/fiat-output/fiat-output.repository';
import { CheckoutTxRepository } from 'src/subdomains/supporting/fiat-payin/repositories/checkout-tx.repository';
import { PayInRepository } from 'src/subdomains/supporting/payin/repositories/payin.repository';
import { TransactionSpecificationRepository } from 'src/subdomains/supporting/payment/repositories/transaction-specification.repository';
Expand Down Expand Up @@ -43,6 +44,7 @@ export class RepositoryFactory {
public readonly lmOrder: LiquidityManagementOrderRepository;
public readonly lmRule: LiquidityManagementRuleRepository;
public readonly custodyOrder: CustodyOrderRepository;
public readonly fiatOutput: FiatOutputRepository;

constructor(manager: EntityManager) {
this.user = new UserRepository(manager);
Expand All @@ -65,5 +67,6 @@ export class RepositoryFactory {
this.lmOrder = new LiquidityManagementOrderRepository(manager);
this.lmRule = new LiquidityManagementRuleRepository(manager);
this.custodyOrder = new CustodyOrderRepository(manager);
this.fiatOutput = new FiatOutputRepository(manager);
}
}
2 changes: 2 additions & 0 deletions src/subdomains/core/monitoring/health.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,14 @@ export class HealthController {
private checkPayment(state: SystemState | null): { status: HealthStatus; detail?: string } {
const data = state?.payment?.combined?.data as {
stuckPayments?: number;
stuckFiatOutputs?: number;
unhandledCryptoInputs?: number;
};
if (!data) return { status: HealthStatus.DEGRADED, detail: 'No payment data' };

const issues: string[] = [];
if (data.stuckPayments > 0) issues.push(`${data.stuckPayments} stuck quotes`);
if (data.stuckFiatOutputs > 0) issues.push(`${data.stuckFiatOutputs} stuck fiat outputs`);
if (data.unhandledCryptoInputs > 5) issues.push(`${data.unhandledCryptoInputs} unhandled inputs`);

if (issues.length === 0) return { status: HealthStatus.OK };
Expand Down
6 changes: 6 additions & 0 deletions src/subdomains/core/monitoring/observers/payment.observer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ interface PaymentData {
bankTxGsType: number;
refRewardManualCheck: number;
stuckPayments: number;
stuckFiatOutputs: number;
pendingCustodyOrders: number;
}

Expand Down Expand Up @@ -108,6 +109,11 @@ export class PaymentObserver extends MetricObserver<PaymentData> {
),
created: LessThan(Util.hoursBefore(3)),
}),
stuckFiatOutputs: await this.repos.fiatOutput.countBy({
isReadyDate: LessThan(Util.hoursBefore(1)),
isTransmittedDate: IsNull(),
isComplete: false,
}),
pendingCustodyOrders: await this.repos.custodyOrder.countBy({
status: CustodyOrderStatus.CONFIRMED,
type: Not(In(CustodyIncomingTypes)),
Expand Down