feat(monitoring): add stuck fiat outputs metric to payment observer#3876
Merged
Conversation
Fiat outputs can fail transmission to the bank (e.g. Olkypay model validation errors) and then sit ready but untransmitted indefinitely, visible only in the entity info column. Count outputs with isReadyDate older than one hour and no isTransmittedDate in the payment observer and surface them in the health check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fiat outputs that fail transmission to the bank (e.g. Olkypay model validation errors like
CLIENT_INVALID_ZIPCODE) sit ready but untransmitted indefinitely — the error is only visible in the entityinfocolumn, with no monitoring alert.stuckFiatOutputsmetric in the payment observer: counts fiat outputs withisReadyDateolder than 1 hour, noisTransmittedDate, andisComplete = falseN stuck fiat outputs)FiatOutputRepositoryregistered inRepositoryFactoryTest plan
npm run type-checknpx eslinton changed files