Skip to content

chore: drop PyPI publishing pipeline (#267) - #488

Merged
CryptoJones merged 1 commit into
mainfrom
chore/drop-pypi-publishing
Oct 27, 2026
Merged

CryptoJones merged 1 commit into
mainfrom
chore/drop-pypi-publishing

Conversation

@CryptoJones

Copy link
Copy Markdown
Owner

What

omind is an MCP server installed from source with uv tool, not a Python library distributed on PyPI. The project owner has no PyPI account and does not want a public package, so the trusted-publishing pipeline is being removed and #267 closed won't-do.

Changes

  • Remove .github/workflows/publish.yml. Every release since v9.7.3 ran this workflow and failed closed on invalid-publisher (no registered trusted publisher), uploading nothing. Those red release runs are the only thing it produced.
  • De-reference PyPI in CONTRIBUTING.md (Releasing section now describes the GitHub-release / uv tool install path), AGENTS.md, docs/self-update.md, and BACKLOG.md (removed the open [Priority 7 / P3] First PyPI publish of omind package (v8.8.0+) #267 item and the "PyPI Publish Setup" section).
  • Keep the test.yml wheel job — it validates packaging for the uv-tool install path, not an upload — and fix its stale publish.yml comment.
  • CHANGELOG Unreleased entry under Removed.

Releases stay GitHub releases on v<version> tags that the fleet installs from git; nothing uploads to any package index.

Verification

  • ruff check . — clean (the only lint gate in CI).
  • Full pytest — 3967 passed, 16 skipped, 1 xfailed; the 2 test_name_timelines decoy failures are pre-existing on clean main, unrelated to this change.
  • No test reads the edited docs/workflow files.

Closes #267

Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/

🤖 Generated with Claude Code

https://claude.ai/code/session_0124qGFyZJsujDwvAPf9au5m

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

📝 Summary

Summary by CodeRabbit

  • Changes
    • Releases are now distributed through GitHub source tags rather than a Python package index. Install and upgrade the app from its GitHub repository using uv tool.
  • Documentation
    • Updated release, installation, and update guidance to reflect GitHub source-based distribution.
    • Removed instructions for publishing packages to PyPI.

The pull request removes the PyPI publishing workflow and updates release, installation, backlog, and handoff text. The documentation describes GitHub releases and installation from GitHub source.

Changes: Release workflow

Layer / File(s) Summary
Remove distribution publishing workflow
.github/workflows/publish.yml, .github/workflows/test.yml
The PyPI publishing workflow was removed, including its release and manual triggers, version checks, build and validation steps, and conditional upload. The wheel-build comment no longer refers to that workflow.
Document GitHub-source release model
CONTRIBUTING.md, docs/self-update.md, CHANGELOG.md, BACKLOG.md, AGENTS.md
Release and installation documentation now describes GitHub releases and GitHub source installation. The backlog and handoff text no longer lists the PyPI publishing setup as an open item.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to 555f7

No verified merge-blocking risk remains in the workflow or documentation changes.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Linked Issues check Warning Issue #267 is open and directly linked, so its requirements apply. It asks for a first PyPI publish of omind. Its steps are: register the package name, configure an API token or trusted publishing, ad… Either (a) add the publish job to .github/workflows/test.yml and the uv publish step that #267 specifies, or (b) have the maintainer close or rescope #267 so that its requirements no longer apply, then reassess this PR against the updated i…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: removing the PyPI publishing pipeline.
Description check Passed The description directly explains the removal of the PyPI workflow, documentation updates, retained wheel validation, release behavior, and verification results.
Out of Scope Changes check Passed All changed files relate to the PyPI publishing path that #267 covers, or to the won't-do decision in the PR description. The deletion of .github/workflows/publish.yml removes the publish pipeline. Th…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Full details: Out of Scope Changes check

Explanation

All changed files relate to the PyPI publishing path that #267 covers, or to the won't-do decision in the PR description. The deletion of .github/workflows/publish.yml removes the publish pipeline. The edits to CONTRIBUTING.md, AGENTS.md, docs/self-update.md, and BACKLOG.md remove PyPI references and the open #267 backlog item. The CHANGELOG.md Unreleased entry records the removal. The test.yml change only updates a comment in the wheel job, which replaces the stale publish.yml reference. No change in the diff concerns unrelated functionality. The changes are consistent with the PR objective, but they reverse the publish work that #267 requests. That conflict is assessed under linkedIssuesAssessment.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

Full details: Linked Issues check

Explanation

Issue #267 is open and directly linked, so its requirements apply. It asks for a first PyPI publish of omind. Its steps are: register the package name, configure an API token or trusted publishing, add a publish job to .github/workflows/test.yml when using trusted publishing, and run uv publish. The reviewed head does not meet these requirements. The PR deletes .github/workflows/publish.yml and adds no publish job. The head file list for .github/workflows shows only codeql.yml and test.yml. The only test.yml change is a comment edit in the wheel job. The PR description states that #267 is closed as won't-do. That decision is not a code change, and the issue remains open in the linked data. The non-coding steps (name registration, token creation) do not affect this result. The coding requirements (publish job, publish step) are unmet.

Resolution

Either (a) add the publish job to .github/workflows/test.yml and the uv publish step that #267 specifies, or (b) have the maintainer close or rescope #267 so that its requirements no longer apply, then reassess this PR against the updated issue state.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

omind is an MCP server installed from source with `uv tool`, not a library
distributed on PyPI, so the trusted-publishing release pipeline was never
needed. The project owner has no PyPI account and does not want a public
package, so #267 is closed won't-do.

Removes `.github/workflows/publish.yml` (every release since v9.7.3 failed
closed on `invalid-publisher`, uploading nothing) and the PyPI references in
CONTRIBUTING.md (Releasing), AGENTS.md, docs/self-update.md, and BACKLOG.md
(open item + "PyPI Publish Setup" section). The test.yml wheel job stays with
its stale publish.yml comment fixed. Releases remain GitHub releases on
`v<version>` tags that the fleet installs from git.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0124qGFyZJsujDwvAPf9au5m
@CryptoJones
CryptoJones force-pushed the chore/drop-pypi-publishing branch from ff364fc to 555f73a Compare October 27, 2026 07:27

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔇 Additional comments: 1
CHANGELOG.md-10-10: 1

10-10: Minor · Maintainability & Code Quality · Quick win

⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Add a blank line after the ### Removed heading.

markdownlint-cli2 reports MD022 because the heading is not separated from the following list. Insert one blank line after Line 10.

Source: Linters/SAST tools


Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: be8bf68b-a800-4393-b440-e3e73dcdec58
Commits

Reviewing files that changed from the base of the PR and between 3110dcd and 555f73a.

Files selected for processing: 7
  • .github/workflows/publish.yml
  • .github/workflows/test.yml
  • AGENTS.md
  • BACKLOG.md
  • CHANGELOG.md
  • CONTRIBUTING.md
  • docs/self-update.md
Files with no reviewable changes: 2
  • BACKLOG.md
  • .github/workflows/publish.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Review details
Context from checks skipped due to timeout: 11
  • GitHub Check: test (macos-latest, 3.10)
  • GitHub Check: test (ubuntu-latest, 3.11)
  • GitHub Check: test (windows-latest, 3.10)
  • GitHub Check: test (ubuntu-latest, 3.13)
  • GitHub Check: test (ubuntu-latest, 3.14)
  • GitHub Check: test (ubuntu-latest, 3.12)
  • GitHub Check: test (windows-latest, 3.14)
  • GitHub Check: Upgrade from latest (windows-latest)
  • GitHub Check: test (macos-latest, 3.14)
  • GitHub Check: test (ubuntu-latest, 3.10)
  • GitHub Check: Upgrade from v9.4.0 (windows-latest)
Additional context used
Code guidelines: 1
CONTRIBUTING.md — auto-discovered
Path-based instructions: 1
Applicability reference: AGENTS.md: # AGENTS.md — orientation for AI agents working on omind For dev setup, the four quality gates, the module map, SemVer rules, and PR conventions, see **[CONTRIBUTING.md](CONTRIBUTING.md)** — this file doe...

CodeRabbit inference engine (CONTRIBUTING.md)

Files:

  • CHANGELOG.md
markdownlint-cli2 (0.23.3)
CHANGELOG.md

[warning] 10-10: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

Additional comments: 4
.github/workflows/test.yml: 1

77-77: LGTM!

CONTRIBUTING.md: 1

127-129: LGTM!

docs/self-update.md: 1

82-84: LGTM!

AGENTS.md: 1

68-68: LGTM!

Also applies to: 135-135

@CryptoJones
CryptoJones merged commit 00e2e29 into main Oct 27, 2026
23 checks passed
@CryptoJones
CryptoJones deleted the chore/drop-pypi-publishing branch October 27, 2026 07:37
CryptoJones added a commit that referenced this pull request Oct 28, 2026
Brings back publish.yml (dropped in #488) now that the owner has a PyPI
account. It authenticates with the PYPI_API_TOKEN secret of the `pypi`
environment instead of trusted publishing, so no pypi.org publisher setup
is needed. The rest is unchanged: build sdist + wheel with `uv build`,
check the release tag matches the pyproject version, `twine check
--strict`, and upload from a separate job that alone enters the `pypi`
environment. Bumps to 10.3.4 so the first upload is a fresh release.


Claude-Session: https://claude.ai/code/session_0124qGG3VAhh8Wmy5Uy2G2v8

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Priority 7 / P3] First PyPI publish of omind package (v8.8.0+)

1 participant