Repository navigation
Runs read the store; YAML retired (#109) - #124
Merged
Merged
Conversation
load_config() reads the roster from the store and fetch_keys() decrypts the secrets from it. `--config` names one store for both halves of a run and is forwarded to --each children as before. `pass` is now needed only for the DB key: one `pass show` per process instead of one per lane secret. - A .yaml/.yml --config dies with the import-yaml command that moves it in. - PyYAML is imported only inside import-yaml (read_yaml_config); the run path no longer needs it, and install.sh no longer asks for it. - import-yaml --pull-secrets keeps its own sequential pass reader, with the first-line rule, since fetch_keys() no longer reads pass. - open_db() sets the busy timeout at connect, so journal_mode=WAL cannot race when --each -j N children open the store together. - DEFAULT_CONFIG is the store path, so skill/toolpanel.py runs unchanged. - FlatlineRoundtable.yaml.example moves to tests/fixtures/legacy-example.yaml (the import-yaml fixture, and still the annotated reference for every option); examples/full-roster.yaml becomes full-roster.json; ci-config.yaml is gone, replaced by ci-roster.json. - Tests build stores with make_db() instead of writing c.yaml, under a throwaway key file. New: store secret reaches the Authorization header end to end with no pass on PATH; wrong DB key; missing secret; a YAML --config is refused. The import-yaml tests skip without PyYAML. - CI installs cryptography only, runs the suite once more with PyYAML on 3.14 for import-yaml, builds the --list store from ci-roster.json, and checks that the YAML refusal and the single lazy `import yaml` hold. - install.sh enforces Python 3.11+ and cryptography and prints the db init / import-yaml next steps. README, CLAUDE.md, SKILL.md and .gitignore describe the store, the DB key, and that a store failure never fails a paid run. Part of #105 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UFaYYNp3Pb6CnndLuW1sj1
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109
Part of #105
What
load_config()reads the roster from the store andfetch_keys()decrypts secrets from it.--confignames one store for both halves of a run and is forwarded to--eachchildren as before.passis now needed only for the DB key, onepass showper process..yaml/.yml--configdies with theimport-yamlcommand that moves it in.import-yaml. The run path andinstall.shno longer need it.import-yaml --pull-secretskeeps its own sequentialpassreader with the first-line rule.open_db()sets the busy timeout at connect, sojournal_mode=WALcannot race under--each -j N.DEFAULT_CONFIGis the store path, soskill/toolpanel.pyruns unchanged.FlatlineRoundtable.yaml.examplemoves totests/fixtures/legacy-example.yaml. It is theimport-yamlfixture and still the annotated reference for every option.examples/full-roster.yamlbecomesfull-roster.json, andci-config.yamlis replaced byci-roster.json.make_db(). New tests cover a store secret reaching theAuthorizationheader end to end with nopasson PATH, a wrong DB key, a missing secret, and a refused YAML--config.cryptographyonly, reruns the suite with PyYAML on 3.14 forimport-yaml, builds the--liststore fromci-roster.json, and checks the YAML refusal and the single lazyimport yaml.install.shenforces Python 3.11+ andcryptography. README, CLAUDE.md, SKILL.md and.gitignoredescribe the store, the DB key, and that a store failure never fails a paid run.Lane dicts do not yet carry
lane_id/version, which the issue sketched. Nothing reads them yet; the consumers (#80 follow-ups, #89) can add them.Manual gate (makemake, store imported in #123)
Verified
233 tests pass on Python 3.11 without PyYAML (9 import-yaml tests skip) and on 3.14 with it.
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/
🤖 Generated with Claude Code
https://claude.ai/code/session_01UFaYYNp3Pb6CnndLuW1sj1