Skip to content

test(core): lock exact DNS and origin port bounds - #340

Draft
seonghobae wants to merge 2 commits into
mainfrom
test-origin-exact-bounds-20261002
Draft

seonghobae wants to merge 2 commits into
mainfrom
test-origin-exact-bounds-20261002

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

상태

  • lifecycle: Draft / exact-boundary regression
  • exact head: ad50387bebad48bec1b6b1267cbe55f961d55924
  • base: main@87c4daa1830bac5a5228b6036752ad5633232085

유효 delta

기존 parser 동작의 accepted maxima를 고정합니다: 63-byte DNS label, 253-byte DNS host, DNS/IPv6 authority port 65535. 인접 64/254-byte 및 65536 rejection은 유지합니다. Production parser와 network capability는 변경하지 않습니다.

exact-head gates

  • CI 36926740034: GREEN
  • Security 36926739958: GREEN
  • Semgrep 36926740117: GREEN
  • Manifest V3 36926739977: GREEN
  • CodeQL PR 36926739858: RED

기존 본문의 “queued” 상태는 stale입니다. CodeQL RED RCA/repair와 unchanged exact-head rerun, zero unresolved review findings, qualifying independent approval 전에는 Ready/merge할 수 없습니다. Local mutation/review evidence는 hosted required gate를 대체하지 않습니다.

2026-10-05 KST: IPv6 기본 포트 receipt 후속 검증·게시

현재 게시 head는 0211c43c11f06e5732fc73f699e6c264d2eb7c95이며 parent ad50387bebad48bec1b6b1267cbe55f961d55924, 검토 tree 24635aa6d7048207539f126a1159f1b0243030a4입니다. 원본 base→최종 전체4경로/214파일의 독립 SOURCE 보고서 SHA-256은 dcc62ec3fa7fe8a3e4e78663274abfee6c4a4f2195ab28f3fde176f540f05700입니다. 기존63/253DNS 및65535포트 테스트를 포함해 전체변경을 검토했습니다. 비차단 IPv6:65536 추가제안은 이번 검토된bytes에 섞지 않았습니다.

증분3파일에 HTTPIPv6loopback explicit:80의정확canonical문자열과implicit-origin equality를추가하고CHANGELOG/TEST_STRATEGY를갱신했습니다. 기존올바른production의first-GREEN characterization이며production수리가아닙니다. private:80잔존corruption은oldcontrolPASS/newassertionexit101/restored8PASS로분리했습니다.

실제채택checkout의fmt/focused8이통과한뒤정상commit을생성했습니다. exactcommitted9게이트는Rust278/Python152/failedignored0 및functions521/521,lines4420/4420,regions5349/5349,branches654/654각100%입니다. committedcoverageSHA-256 2218ed09526d380ca1fbf5970cac4d43ae3f3e16b6670c40c5d546ab6f2aeb23은private후보measurement와별도입니다. outer400초batch가gate0/1후gate2도중종료된기록과partiallog를보존하고해당group부재를확인했습니다. 그누락gate만같은source·명령·350초childdeadline으로새log에실행했고나머지gate를완료했습니다. 제품deadline/assertion완화나성공gate재실행은없습니다.

동일기존GitHubidentity개인S1에서publicsourcebundle1465B의hash/parent/tree/전체214source를검산한후각1회의정상non-forcepush를완료했습니다.16remote단계의exit/loghash/ownedgroup정산을확인했고초기PRref전파lag뒤branch·PRref·authenticatedhead가일치했습니다. credential전달/영구helper/빌링/runnergroup/ACL/workflow/protection변경은없습니다.

현재Draft입니다. 최신run37225076515의Rust/coverage와37225076590의MV3job은실행되지않은SKIPPED이며steps[]입니다. 실제workflow의draft==false조건과별도lifecycle관측을확인했습니다. Draft는2026-10-01T22:25:54Z(10월2일07:25:54KST)convert기록에있으며이번게시로새로만든것이아닙니다. 동적CodeQuality37225074247/job111502948560은billinglock startup FAILURE/runner0/steps0입니다. CodeRabbit/Devin SUCCESS는정식current-head approval이아닙니다. 기존Ready전실게이트·리뷰정산조건을임의해제하거나Ready-toggle로green을만들지않았습니다. 원본문oldheadGREEN은역사기록이고현재head실행증거가아닙니다. currentCI/security/필요approval/normalmerge·원Goal은미완료입니다.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c5c621b5-bc40-4b32-83f5-f601f9be5d5d

📥 Commits

Reviewing files that changed from the base of the PR and between 87c4daa and ad50387.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • crates/originweave-core/tests/coverage_edges.rs
  • docs/TEST_STRATEGY.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

DNS 레이블·호스트와 DNS·IPv6 권한의 포트 최댓값을 확인하는 회귀 테스트를 추가했습니다. 한도를 초과한 값의 거부도 확인합니다. 변경 기록과 테스트 전략 문서를 갱신했습니다. 프로덕션 파서 동작은 변경하지 않았습니다.

Changes

Origin 파서 경계값

Layer / File(s) Summary
경계값 회귀 테스트와 기록
crates/originweave-core/tests/coverage_edges.rs, docs/TEST_STRATEGY.md, CHANGELOG.md
63바이트 DNS 레이블, 253바이트 DNS 호스트, 도메인 및 IPv6 권한의 포트 65535가 파싱되는지 확인합니다. 64바이트 레이블과 254바이트 호스트의 거부도 테스트합니다. 테스트 전략과 변경 기록에 해당 내용을 추가했습니다.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to ad503

This PR adds regression coverage and matching documentation without changing parser behavior. No concrete product-impacting merge risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 1 files. (2 skipped: 2 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 DNS와 origin 포트의 정확한 경계값을 고정하는 테스트 변경을 간결하고 구체적으로 요약합니다.
✨ Finishing Touches 💡 1
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant