chore(metadata): record public-surface label taxonomy wave 3 - #1653
seonghobae wants to merge 146 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true📝 WalkthroughWalkthrough저장소 라벨 taxonomy와 운영 기록에 대상 매핑을 추가·수정했습니다. 라벨 reconciliation은 병렬 실행과 일괄 오류 출력을 사용합니다. 워크플로 트리거와 taxonomy 검증 테스트도 갱신했습니다. Changes저장소 라벨 reconciliation
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🟡 Moderate · up to This change expands centrally reconciled labels and parallelizes their application, but it currently assigns an incorrect semantic label to disksage#315, records an inaccurate wave-3 inventory, and can cause nondeterministic test failures. Correct these issues before merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fresh organization traversal found three additional evidence-backed semantic-type targets that are not in the current 61-target exact assignment set and should be folded into this same taxonomy lane (or its direct successor after re-reading the current head), rather than opened as a competing manifest writer:
Also corrected repository-local workflow status where fresh evidence showed a real prerequisite/control-plane blocker rather than mere review wait: When extending the exact assignment list, update the exact-set test and operating-record count together; do not weaken exact matching or transfer queued/predecessor evidence. |
|
Fresh organization-label reconciliation found three additional evidence-backed documentation targets that are not yet present in this branch's exact assignment inventory: |
|
One desired-state correction from the same pass: |
|
A second primary-type correction: |
Preserve the live security-owner and Gap-evidence lineage while merging the independently reviewed RED-to-GREEN repair that removes urlopen suppressions, accepts one credential-free HTTPS redirect only to the exact GitHub release-assets host, bounds reads, and closes every response/connection path. Local exact-tree evidence: 16 focused tests passed; git diff --check passed. The same repair on the immediately preceding owner tree passed 5,178 tests, 8 skipped, and 40 subtests, and independent review reported zero Critical, Important, or Minor findings. Fresh hosted exact-head evidence remains mandatory.
Replace only the corrupted 120,060-byte binary payload with the last complete 3,678-line UTF-8 baseline from the immediate valid predecessor. Preserve the SAST transport repair and all other a5ddcfc changes. Fresh exact-head hosted evidence remains required.
Complete the Semgrep transport repair by constructing the urllib opener with ProxyHandler({}). This prevents environment-derived HTTPS proxy authorities and proxy credentials from entering the fixed GitHub-to-release-assets request path while preserving the reviewed one-hop redirect handler.
RED-to-GREEN: the bounded-download contract first required an explicit empty proxy map and failed when build_opener received only the redirect handler. Final focused verification: 16 passed; compileall and git diff --check passed. Independent offline replay with a credential-bearing https_proxy confirmed exclusion, and re-review reported zero Critical, Important, or Minor findings. Fresh hosted exact-head evidence remains mandatory.
Preserve the live exact-head SAST RCA documentation and the independently reviewed ProxyHandler({}) repair as ordinary parents. The merged tree retains the restored complete Gap baseline, fixed one-hop redirect handler, ambient proxy/auth exclusion, focused GREEN evidence, and all release HOLD language.
Focused exact-tree verification: 16 passed; git diff --check passed. Fresh hosted exact-head evidence and qualifying approval remain mandatory.
Preserve the existing combined #2530 successor as first parent and integrate current #2531 as canonical security owner. The conflict resolution retains every downstream #2530 Gap row while carrying the complete owner RCA, proxy-free bounded downloader, exact one-hop redirect policy, executable contracts, and SAST closure evidence. Exact local verification: 31 focused tests passed; compileall, Ruff, and git diff --check passed.
2026-10-01 failed Checks RCA — canonical owner stack consumedPrevious exact head
Current head Fresh local focused verification on that exact merge tree: 32 tests passed across metadata live/workflow contracts plus Noema/Strix dependency contracts; New current-head runs are Repository Metadata |
Reproduce the exact Trusted uv 99% branch-coverage failure from run 36811202519, job 110206427182. Exercise non-200 and opener-raised HTTPError closure, and replace the impossible nullable-response branch with one unconditional response-owned close scope. Preserve the exact host, redirect, byte, digest, timeout, and fail-closed boundaries. Focused evidence: 17 passed; verify_release_maturin_tool_assets.py 107/107 statements and 34/34 branches; compileall and git diff --check GREEN. Full local collection reached 5,311 passed, 5 skipped, and 40 subtests; two unrelated native fixture cases failed because the ephemeral local environment lacked the maturin executable, so hosted exact-head full-suite evidence remains authoritative and required.
Bind the Maturin verifier source and focused regression test to both pull-request and protected-branch paths of the complete Trusted uv quality gate. The test-only trigger contract reproduces the omission before the workflow repair. Focused evidence: 24 passed; verifier 107/107 statements and 34/34 branches; workflow YAML parse, compileall, and git diff --check GREEN.
Run the read-only complete Trusted uv quality gate for every pull-request base instead of only PRs targeting main. Preserve the protected-main push scope. A RED-to-GREEN workflow contract proves that canonical owner stacks cannot suppress exact-head evidence. Focused evidence: 25 passed; verifier 107/107 statements and 34/34 branches; YAML parse and git diff --check GREEN.
Ordinary two-parent merge preserves the complete #1653 label-taxonomy delta and consumes canonical #2530 exact head dc54310. The owner head repairs Maturin response closure, restores 100% full-suite branch evidence, and admits stacked quality checks. Owner hosted evidence: Trusted uv Materializer Quality CI run 36813245691 GREEN with 5,314 passed, 5 skipped, 40 subtests, 18,767/18,767 statements and 7,648/7,648 branches; Security, SAST, and Metadata GREEN. Local merge-tree evidence: 25 focused tests, verifier 107/107 statements and 34/34 branches, and git diff --check GREEN. Fresh consumer exact-head hosted checks remain required.
|
Consumed canonical coverage owner #2530 by ordinary two-parent merge at exact head Owner exact-head Trusted uv Materializer Quality CI 36813245691 is terminal GREEN: 5,314 passed, 5 skipped, 40 subtests; production 18,767/18,767 statements and 7,648/7,648 branches. Owner Security, SAST, and Metadata are also GREEN. Local merge-tree evidence is 25 focused tests, verifier 107/107 statements and 34/34 branches, and clean Fresh consumer exact-head hosted Checks are now required. The PR remains Draft / Proposed; Draft-skipped CodeQL is not acceptance, and no prior-head evidence is promoted. No force update, rebase, gate weakening, threshold change, self-approval, or predecessor closure was used. |
|
Consumer exact-head revalidation update for At this same exact head, Security run |
|
Final exact-head check update: Agent Review Runtime Quality run 36813668125, job |
2026-10-01 21:14 UTC handoff continuationThe prior handoff comment reached GitHub's body limit; this comment continues the same evidence ledger.
Predecessor ledger: #1653 (comment)
2026-10-02 — seedream_evasepic#538 post-writer repair
2026-10-02 — EmbedRelay#4 CodeQL RCA and review metadata
|
Outcome
Record evidence-backed repository issue/PR semantic types in the organization-owned label taxonomy so live classifications remain idempotent rather than one-off mutations.
The current branch doctoring record covers 175 active evidence-backed targets: a reconciled 47-target operating baseline plus 128 reviewed wave-3 targets. The central taxonomy owns the managed primary semantic labels (
feature -> enhancement,bug -> bug,documentation -> documentation); richer repository-local priority, workflow-status, security, maintenance, architecture, component, andtype: maintenancelabels remain outside that managed semantic set.Successor / stale-target reconciliation
The active inventory follows current canonical writers instead of retaining stale issue identities merely to keep counts stable. Existing branch history records successor carryover including
codec-carver#514→codec-carver#516,g7#2→g7#3, mergedpsychometrics-commons#442→ currentpsychometrics-commons#434, supersededscopeweave#650→scopeweave#651, and complete carryover for retiredcontextual-orchestrator#1003andaccounting-information-platform#45into already-recorded canonical targets.The current taxonomy blob is
2af5f823dea1e463edc38a4bf80295ace6831f2e. Current head additionally integrates the live-read assignments forpg-erd-cloud#1100,.github#2037/#2039,naruon#1603/#1604/#1605/#1606/#1607/#1608/#1609,appguardrail#1182/#1183,litellm-patched-proxy#5,9drive#4,ConceptWeave#40,noema#560, andquarantine-sandbox-runtime#99/#100; tests intentionally pin exact inventory/blob identity, and the operator records must move atomically with any assignment change. Fresh traversal has added coordination on this PR for newly classified targets such asnaruon#1541,learning-record-store#6,ContextualWisdomLab.github.io#204,pg-erd-cloud#1061,naruon#1500,html4tree#590,contextual-orchestrator#1028,naruon#1539, andpingora-gateway#17; those are live repository classifications but are not claimed as integrated taxonomy entries until this branch's config/test/doctoring set is updated together.Exact authority — 2026-09-27
GitHub reports this PR open, Draft, and mechanically mergeable. Current exact head is
04f8d5135065498dce50b2150e4fa986e70ac60f.The stale-base repair was performed without force-push. RED commit
d8e7521de73035e81590f15db84636d2313da6f8proves that repository names containing..or ending in.were accepted. Two-parent merge04f8d5135065498dce50b2150e4fa986e70ac60fpreserves that test and current protectedmain@e6334e229581a918e2f22de18733b76fa65d7e71; its tree is056d79a255439ec68aad299902b058e3111a0c6c. The main-side stricter repository-name validation and branch-side boundedThreadPoolExecutorreconciliation are both present.Fresh compare is ahead 63 / behind 0 with protected
mainas the merge base and exactly eight changed files. A detached checkout of the exact remote head passed all 19 label reconciliation/taxonomy tests, Python compilation, taxonomy--validate-only, andgit diff --check.Exact-head Repository Metadata Reconcile
36271689379, CodeQL PR36271689369, SAST Semgrep36271689346, Security Scan36271689383, and Python Security36271689343are queued. The Reviews API still contains aCHANGES_REQUESTEDverdict and has zero independent approvals; all inline threads are resolved. Draft status remains correct and this PR must not merge until current-head Checks and review admission settle.The branch currently carries 63 commits and eight changed files. Continue preserving the single writer: live classification increments recorded in PR comments are not integrated until config, exact inventory tests/fixtures, and operator records move atomically on this branch.
Governance / concurrency
This branch is independent of Draft metadata desired-state PR #1639, which owns repository descriptions/topics/Pages intent. No branch protection, repository settings, Pages settings, secrets, review rules, or leaf repository source is changed here.
The recorded classifications do not make Draft work Ready, unblock blocked work, transfer merge authority, or waive exact-head checks/reviews. A source assignment is not live convergence evidence until repository labels are re-read after protected integration.
Summary by CodeRabbit
새 기능
문서
테스트