Skip to content

Handle stray BadQueryErrors (#249) #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSpaceships merged 1 commit into from
Feb 4, 2026
Merged

Handle stray BadQueryErrors (#249) #252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions profiles/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,13 @@ def home(info=None):
@auth.oidc_auth("default")
@before_request
def user(uid=None, info=None):
return render_template("profile.html", info=info, member_info=get_member_info(uid))
try:
return render_template("profile.html", info=info, member_info=get_member_info(uid))
except BadQueryError as bqe:
# ldap_get_member() returns a BadQueryError if getting the user's information fails.
# Flask already treats a stray BadQueryError as a 404, but actually handling it prevents the traceback
# from getting dumped into the log.
return render_template("404.html", message=bqe), 404


@app.route("/results", methods=["POST"])
Expand Down Expand Up @@ -172,7 +178,10 @@ def logout():

@app.route("/image/<uid>", methods=["GET"])
def image(uid):
return get_image(uid)
try:
return get_image(uid)
except BadQueryError as bqe:
return render_template("404.html", message=bqe), 404


@app.route("/clearcache")
Expand Down