Handle stray BadQueryErrors (#249) #252
Open
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ldap_get_member()returns aBadQueryErrorwhenever getting a user's information fails, and currently this goes uncaught in the/user/<uid>and/image/<uid>. Flask already handles an uncaughtBadQueryErrorby presenting a 404 page, but the exception is still throw out into the console.This PR just makes it so those endpoints will catch a
BadQueryErrorand return the 404 page directly, rather than letting it go uncaught and having it fall back onto Flask to handle it. (Fix for #249)