Skip to content

[FIX] Do not iterable on null error if adoptedStyleSheets is undefined #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaspar-chefdeville wants to merge 1 commit into from
Closed

[FIX] Do not iterable on null error if adoptedStyleSheets is undefined #777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export function registerCss(module: { default?: string | CSSStyleSheet } | undef
fontFaceStyleSheet.insertRule(fontFace)
}
mainWindow.document.adoptedStyleSheets = [
...mainWindow.document.adoptedStyleSheets,
...(mainWindow.document.adoptedStyleSheets ?? []),
Copy link
Contributor

@CGNonofr CGNonofr Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is adoptedStyleSheets undefined? because I agree it will prevent the error from being triggered, but it most probably means that adoptedStyleSheets is not supported at all, so all the styleSheets won't work anyway and the page will still be unusable 🤔

adoptedStyleSheets is supported in all major browsers since 2024 for the latest, so I'm wondering 🤔

fontFaceStyleSheet
]
}
Expand All @@ -55,5 +55,5 @@ export function injectCss(target: HTMLElement) {
)
}

root.adoptedStyleSheets = [...root.adoptedStyleSheets, ...sheets]
root.adoptedStyleSheets = [...(root.adoptedStyleSheets ?? []), ...sheets]
}
Loading