[FIX] Do not iterable on null error if adoptedStyleSheets is undefined#777
Closed
gaspar-chefdeville wants to merge 1 commit intomainfrom
Closed
[FIX] Do not iterable on null error if adoptedStyleSheets is undefined#777gaspar-chefdeville wants to merge 1 commit intomainfrom
gaspar-chefdeville wants to merge 1 commit intomainfrom
Conversation
CGNonofr
reviewed
Mar 16, 2026
| } | ||
| mainWindow.document.adoptedStyleSheets = [ | ||
| ...mainWindow.document.adoptedStyleSheets, | ||
| ...(mainWindow.document.adoptedStyleSheets ?? []), |
Contributor
There was a problem hiding this comment.
When is adoptedStyleSheets undefined? because I agree it will prevent the error from being triggered, but it most probably means that adoptedStyleSheets is not supported at all, so all the styleSheets won't work anyway and the page will still be unusable 🤔
adoptedStyleSheets is supported in all major browsers since 2024 for the latest, so I'm wondering 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.