Skip to content

chore(deploy): deploys fire on merge to main only — drop pull_request preview deploys #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eaitbrahim merged 1 commit into from
Aug 20, 2026
+9 −6
Merged

chore(deploy): deploys fire on merge to main only — drop pull_request preview deploys #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
name: Deploy

# FR-1/FR-12 — one workflow owns every deploy:
# - push to main → production deploy (*.pages.dev until the domain lands)
# - pull_request → preview deploy on a branch URL
# FR-1/FR-12 — one workflow owns every production deploy:
# - push to main → production deploy (runs when a PR is merged to main)
# - hourly schedule → fresh build (news/release/docs refresh) + production deploy
# - workflow_dispatch → "right now" button
# pull_request is deliberately NOT a trigger: PRs are validated by CI (ci.yml),
# which builds and uploads a `site-preview` artifact — no per-PR preview deploys.
#
# One-time setup (repo Settings, no Cloudflare dashboard clicks needed):
# Secrets: CLOUDFLARE_API_TOKEN (Cloudflare Pages: Edit), CLOUDFLARE_ACCOUNT_ID
Expand All @@ -14,7 +15,6 @@ name: Deploy
on:
push:
branches: [main]
pull_request:
schedule:
# Hourly at :07, off the top of the hour.
- cron: "7 * * * *"
Expand Down
7 changes: 5 additions & 2 deletions docs/superpowers/specs/2026-08-19-website-prd.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,11 @@ called Keel (keel.sh) and currently owns the bare-"keel" search results.
## 5. Functional requirements

### FR-1 Architecture
Static-first Astro site, deployed on Cloudflare Pages from this repo's `main`; every PR
gets a preview deployment. No server-side runtime except (optionally) one Cloudflare
Static-first Astro site, deployed on Cloudflare Pages from this repo's `main`; deploys
run when a PR is merged to `main` (plus an hourly content refresh and manual dispatch).
PRs are validated by CI, which uploads a build artifact for inspection — no per-PR
preview deployments (amended 2026-08-20; originally "every PR gets a preview
deployment"). No server-side runtime except (optionally) one Cloudflare
Worker scoped to proxying GitHub GraphQL/REST reads with the token (FR-5/6).

### FR-2 Site map (v1)
Expand Down
Loading