chore(deploy): deploys fire on merge to main only — drop pull_request preview deploys - #38
Merged
Conversation
… preview deploys The Deploy workflow no longer runs on pull_request. Production deploys now happen exclusively on push to main (i.e. when a PR is merged), the hourly content refresh, and manual dispatch. PRs stay fully validated by ci.yml — fetch, type check, build — which also uploads a site-preview artifact for inspection, so nothing is lost except the per-PR preview URL (which was publicly reachable and burned a wrangler deploy per push). FR-1 amended accordingly (dated, original wording preserved).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Deploy(.github/workflows/deploy.yml) no longer triggers onpull_request. Production deploys now run only when a PR is merged tomain(push), on the hourly content refresh, or via manual dispatch.ci.ymlruns fetch + type check + build on every PR and uploads asite-previewartifact (7-day retention) for inspection.Why
wrangler pages deployto a publicly reachable preview URL for every push — unnecessary exposure and deploy churn when CI already proves the build.pushdeploy); this removes the redundant third trigger.Also
Verification
pushDeploy run must fire and deploy to production.